This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix undefined variable in ProductSchema.php closure #2962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senadir
added
type: bug
|
Size Change: 0 B Total Size: 1.65 MB ℹ️ View Unchanged
|
nerrad
approved these changes
Aug 6, 2020
There was a problem hiding this comment.
Thanks for taking care of this Nadir. Code wise this is good, but I think our testing notes could include a bit more about what is impacted by this change (in particular anything that interacts with the routes using product schema). Can you expand on that in the testing notes please and include what should be tested to ensure there are no unexpected side-effects of this change?
I'll pre-approve but on the assumption additional testing notes will be added (and you've verified what you note works)
assets/js/blocks/products/utils.js
Outdated
| @@ -35,7 +35,7 @@ export const renderNoProductsPlaceholder = ( blockTitle, blockIcon ) => ( | |||
| className="wc-block-products__add-product-button" | |||
| isDefault | |||
| isLarge | |||
| href={ adminUrl + 'post-new.php?post_type=product' } | |||
| href={ ADMIN_URL + 'post-new.php?post_type=product' } | |||
There was a problem hiding this comment.
this was from another PR, not sure how it got here 😅, props to Albert.
There was a problem hiding this comment.
this was from another PR, not sure how it got here 😅, props to Albert.
senadir
force-pushed
the
fix/undefined-variable
branch
from
a0af100
to
d6504c1
Compare
|
Tested okay, I also verified that there was no impact to variation meta data returned as a result of this change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue by defining
use ( $product )in the closure, as far as my googling went, this syntax is supported from PHP 5.3, so we're safe (WC requires 7.0).Fixes #2896
How to test the changes in this Pull Request:
How to test
0- Make sure you have WP_DEBUG set to true.
1- Load a page that already contains a product data, so single product or All Products, either in the editor or frontend.
2- Make sure no notices are printed to the page, you can check the source code or at the top of the page.
Changelog