Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Fix discounted price misalignment in Cart block #3047

Merged
merged 2 commits into from Aug 25, 2020

Conversation

Aljullu
Copy link
Contributor

@Aljullu Aljullu commented Aug 25, 2020

Fixes #3048.
Fixes #3049.

Screenshots

#3048:
Before:

After:

#3049:
Before:
Peek 2020-08-25 10-58

After:
Peek 2020-08-25 10-57

How to test the changes in this Pull Request:

#3048:

  1. Add a product on sale to the Cart and visit the Cart block.
  2. Verify regular and discounted prices are both aligned to the right (see screenshots above for comparison).

#3049:

  1. Add a product price block.
  2. In the block toolbar, change the alignment option to center or right.
  3. Verify the product price alignment changes accordingly.

Changelog

Fix misalignment of discounted prices in the Cart block.

@Aljullu Aljullu added status: needs review block: cart Issues related to the cart block. focus: global styles Issues that involve styles/css/layout structure. labels Aug 25, 2020
@Aljullu Aljullu added this to the 3.3.0 milestone Aug 25, 2020
@Aljullu Aljullu requested a review from a team as a code owner August 25, 2020 08:40
@Aljullu Aljullu self-assigned this Aug 25, 2020
@Aljullu Aljullu requested review from nerrad and removed request for a team August 25, 2020 08:40
@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2020

Size Change: +20 B (0%)

Total Size: 1.11 MB

Filename Size Change
build/all-products.js 35.7 kB +10 B (0%)
build/atomic-block-components/price-frontend.js 2.09 kB +11 B (0%)
build/atomic-block-components/price.js 2.12 kB +14 B (0%)
build/style-rtl.css 18 kB -7 B (0%)
build/style.css 18 kB -8 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/active-filters-frontend.js 8.76 kB 0 B
build/active-filters.js 8.82 kB 0 B
build/all-products-frontend.js 31.2 kB 0 B
build/all-reviews.js 9.76 kB 0 B
build/atomic-block-components/add-to-cart-frontend.js 8.89 kB 0 B
build/atomic-block-components/add-to-cart.js 7.46 kB 0 B
build/atomic-block-components/add-to-cart~atomic-block-components/button.js 3.16 kB 0 B
build/atomic-block-components/add-to-cart~atomic-block-components/image~atomic-block-components/title.js 335 B 0 B
build/atomic-block-components/button-frontend.js 2.02 kB 0 B
build/atomic-block-components/button.js 839 B 0 B
build/atomic-block-components/category-list-frontend.js 468 B 0 B
build/atomic-block-components/category-list.js 476 B 0 B
build/atomic-block-components/image-frontend.js 1.71 kB 0 B
build/atomic-block-components/image.js 1.15 kB 0 B
build/atomic-block-components/rating-frontend.js 524 B 0 B
build/atomic-block-components/rating.js 527 B 0 B
build/atomic-block-components/sale-badge-frontend.js 863 B 0 B
build/atomic-block-components/sale-badge.js 864 B 0 B
build/atomic-block-components/sku-frontend.js 389 B 0 B
build/atomic-block-components/sku.js 394 B 0 B
build/atomic-block-components/stock-indicator-frontend.js 567 B 0 B
build/atomic-block-components/stock-indicator.js 571 B 0 B
build/atomic-block-components/summary-frontend.js 918 B 0 B
build/atomic-block-components/summary.js 925 B 0 B
build/atomic-block-components/tag-list-frontend.js 466 B 0 B
build/atomic-block-components/tag-list.js 473 B 0 B
build/atomic-block-components/title-frontend.js 1.22 kB 0 B
build/atomic-block-components/title.js 1.06 kB 0 B
build/attribute-filter-frontend.js 18.1 kB 0 B
build/attribute-filter.js 12.4 kB 0 B
build/blocks.js 3.54 kB 0 B
build/cart-frontend.js 69 kB 0 B
build/cart.js 37.4 kB 0 B
build/checkout-frontend.js 84 kB 0 B
build/checkout.js 40.6 kB 0 B
build/editor-rtl.css 13.9 kB 0 B
build/editor.css 13.9 kB 0 B
build/featured-category.js 7.7 kB 0 B
build/featured-product.js 9.94 kB 0 B
build/handpicked-products.js 7.34 kB 0 B
build/price-filter-frontend.js 14.4 kB 0 B
build/price-filter.js 10.2 kB 0 B
build/product-best-sellers.js 7.42 kB 0 B
build/product-categories.js 3.23 kB 0 B
build/product-category.js 8.35 kB 0 B
build/product-new.js 7.58 kB 0 B
build/product-on-sale.js 7.96 kB 0 B
build/product-search.js 3.54 kB 0 B
build/product-tag.js 6.49 kB 0 B
build/product-top-rated.js 7.55 kB 0 B
build/products-by-attribute.js 8.29 kB 0 B
build/reviews-by-category.js 11.8 kB 0 B
build/reviews-by-product.js 13.3 kB 0 B
build/reviews-frontend.js 9.34 kB 0 B
build/single-product-frontend.js 34 kB 0 B
build/single-product.js 10.1 kB 0 B
build/vendors-style-rtl.css 1.03 kB 0 B
build/vendors-style.css 1.03 kB 0 B
build/vendors.js 415 kB 0 B
build/vendors~atomic-block-components/price-frontend.js 5.65 kB 0 B
build/wc-blocks-data.js 7.09 kB 0 B
build/wc-blocks-middleware.js 931 B 0 B
build/wc-blocks-registry.js 2.28 kB 0 B
build/wc-payment-method-bacs.js 790 B 0 B
build/wc-payment-method-cheque.js 787 B 0 B
build/wc-payment-method-cod.js 875 B 0 B
build/wc-payment-method-paypal.js 831 B 0 B
build/wc-payment-method-stripe.js 11.9 kB 0 B
build/wc-settings.js 2.33 kB 0 B
build/wc-shared-context.js 1.53 kB 0 B
build/wc-shared-hocs.js 1.66 kB 0 B

compressed-size-action

@Aljullu Aljullu merged commit 9f085eb into main Aug 25, 2020
@Aljullu Aljullu deleted the fix/cart-price-misalignment branch August 25, 2020 13:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: cart Issues related to the cart block. focus: global styles Issues that involve styles/css/layout structure.
Projects
None yet
3 participants