This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix product element styling class names #3095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +6 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
senadir
approved these changes
Sep 1, 2020
Comment on lines
+2
to
9
| .wc-block-components-product-price--align-left { | ||
| text-align: left; | ||
| } | ||
| .wc-block-components-product-price__align-center { | ||
| .wc-block-components-product-price--align-center { | ||
| text-align: center; | ||
| } | ||
| .wc-block-components-product-price__align-right { | ||
| .wc-block-components-product-price--align-right { | ||
| text-align: right; |
There was a problem hiding this comment.
this change is unrelated to the issue, right? just styling fixes?
There was a problem hiding this comment.
Yes, I wanted to align all class names to follow the same pattern (-- instead of __) even in blocks where there was not an issue.
Thanks @Aljullu - this seems like a fairly safe, robust change, so I'm going to include it. I'll cherry pick into the release branch and do another round of testing with the built plugin. When reviewing the code in this PR and the element blocks, I noticed that some of the styling is hidden behind feature flag. So I'm keen to do a good round of testing with release build to check behaviour is as expected. Examples:
|
haszari
added a commit
that referenced
this pull request
Sep 1, 2020
haszari
added a commit
that referenced
this pull request
Sep 1, 2020
|
I found one regression/issue (maybe preexisting) in Twenty Twenty when testing this, logged a follow up issue: #3097 |
haszari
added a commit
that referenced
this pull request
Sep 2, 2020
* generating changeset for pull request * generating changeset for pull request * 3.3.0 changelog + add woocommerce contributor (#3067) * update min required WooCommerce - 4.2 (out of date!) * require Woo 4.2+ min (L-2 policy) * draft test instructions for new feature in 3.3.0 * add testing instructions for 3.3.0 bug fixes * update TOC for testing instructions and add MIA 3.0-3.2 (!) * add convenient zip file download to testing instructions * update zip file - missed `composer install --no-dev` step * clarify testing instructions for product price block + + remove mention of MIA screenshots * retroactively add release notes for all products child block customization options * add testing instructions for all products child block changes (3.1.0) + + use changelog note for testing headings * Fix product element styling class names (#3095) * Update sale badge align class names to match other element blocks * Update product price align class names to match other element blocks * Fix Product title alignment class names. Fixes #3094 * Make styling attributes apply to Product title block when it's not a link. Fixes #3093 * Linting fixes * add changelog note for #3095 + use standard changelog prefixes * update release date * update zip file link (new test build ft. #3095) * Bumping version strings to new version. Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Rua Haszard <rua.haszard@automattic.com> Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com>
19 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3093.
Fixes #3094.
Screenshots
How to test the changes in this Pull Request:
It would be good to test two additional blocks to make sure there are no regressions:
cc @haszari I'm adding this to the 3.3.0 milestone in case you want to include it, but feel free to move it to 3.4.0 if you don't want to rush this fix.
Changelog