This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix product reviews schema date fields to use new (WP 5.5) date-time format
#3109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haszari
added
focus: rest api
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
|
I notice that the dates are both the same - one maybe should have a timezone offset. Not sure if this is a bug, or if so what impact it would have… |
Aljullu
approved these changes
Sep 3, 2020
There was a problem hiding this comment.
I only tested with WordPress 5.5 - should we test with 5.3 or 5.4 as well?
I tested with 5.4 and everything looked fine. 👌
I notice that the dates are both the same - one maybe should have a timezone offset. Not sure if this is a bug, or if so what impact it would have…
That should depend on the store timezone (in Settings > General > Timezone) that was selected when the review was written. Maybe you had UTC+0?
Yep that was it 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3005
This PR fixes the schema for product reviews API endpoint.
In WordPress 5.5, the
typemust be one of the primitive types; previously we haddate-time.Schemas can declare the intended format of
type: string, and for our dates we should usedate-timeaka RFC3339.So, this PR uses
type: string, format: date-timefor the two review date fields.I did a quick search to see if there were other API dates that should use this format - looks like this is the only API affected.
To test this I added some reviews and an
All Reviewsblock and checked the response.Screenshots
How to test the changes in this Pull Request:
I only tested with WordPress 5.5 - should we test with 5.3 or 5.4 as well?
Also keen to confirm this fixes the
doing it wrongerror - is there a way to reproduce that (onmain/without these changes)? Or is this only validated when POSTing?Changelog