This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Load WC Blocks CSS after editor CSS #3219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
status: needs review
block: checkout
|
Size Change: +1.52 kB (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
nerrad
approved these changes
Sep 30, 2020
src/Assets.php
Outdated
Comment on lines
39
to
41
| // In the editor, we want our stylesheets to load after editor CSS (see #3068). | ||
| // This might be no longer necessary when https://github.com/WordPress/gutenberg/issues/20797 | ||
| // is merged. |
There was a problem hiding this comment.
Should we create an issue for the backlog for removing this extra code when the fix in Gutenberg lands and we can safely remove because the minimum version of WordPress we support has the fix (if so, you could convert this comment to a todo)?
Remove fix to load our stylesheets after editor CSS. See ...Remove fix to load our stylesheets after editor CSS. See #3068 for the rationale of this fix. It should be no longer github.com/WordPress/gutenberg/issues/20797). https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/e07de12ed23db91cd977be4423132f3151573d87/src/Assets.php#L39-L51🚀 This comment was generated by the automations bot based on a
|
|
Could this also be causing the Full Site Editing page in Gutenberg to be completely blank as reported in WordPress/gutenberg#27938? I'm using WooCommerce 4.8.0. I don't have the WooCommerce Blocks plugin installed. |
|
Hi @chvillanuevap, thanks for raising this! I created a new issue so we can investigate it: #3626. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3068.
The issue was caused because editor CSS was leaking into the block. It could be fixed ensuring our CSS is loaded after
wp-edit-post-css. Notice this fix might no longer be needed if WordPress/gutenberg#20797 gets merged into Gutenberg.Screenshots
Before:
After:
How to test the changes in this Pull Request:
Notice the semi-transparent background is not fixed since it's a different issue (#2487).
Changelog