This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Show the phone number field in the billing section when shipping is disabled in settings #3376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -70 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
budzanowski
approved these changes
Nov 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. I was wondering why we only have one phone number field but the link to the thread in the Issue has clarified that.
Works nicely!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the rendering of address fields to a single file so that PhoneNumber (new component) can be rendered in either billing or shipping, depending on visibility, without duplication.
I was going to update context to handle this (hence why I cleaned up some missing docblocks) however, it made more sense to handle this within the address-step component and simply pass around the attributes as before.
Fixes #3231
Fixes #3346
How to test the changes in this Pull Request:
Ensure the phone number field is enabled in block settings, then test 2 cases:
In both scenarios the values should change and be saved as billing information.
Changelog