Handle change to logged-in status in checkout API AJAX requests #3429
Conversation
Started looking at this and got stuck. Here's what's happening:
(Note I haven't pushed any code related to this.) I think what we need to do is return the new customer user ID in the checkout response, alongside the coupon error. But that seems problematic - it's a sign that the request has potential side effects, and this complicates response handling. FYI @nerrad @mikejolley for thoughts - maybe we need to circle back to the issue and decide how best to handle this (my initial attempt doesn't feel like a good solution). |
I think this sounds like the thing to do; it would be handled kind of like the cart updates. Once the customer ID is added in state/context, the rest of the UI can react and hide things like login prompts etc. |
haszari
force-pushed
the
fix/checkout-handle-ajax-login-change
branch
from
3df268c
to
0743162
Compare
Thanks for the hint @mikejolley – I can see now that cart API does something similar, and checkout supports updating the cart alongside an error response. I've got a rough prototype working in this PR now, but there's a bit of work to do to get it polished. Feel free to give me an early code review if you like. The challenge for the checkout API (as I see it) is that the current logic allows anything to throw a |
haszari
force-pushed
the
fix/checkout-handle-ajax-login-change
branch
from
6f20b7b
to
59f9ba5
Compare
haszari
changed the base branch from
trunk
to
fix/checkout-signup-order-processing-logic
|
Rebased and retargeted this off #3454 for now, so this can use the customer ID and nonce returned with error responses. |
|
Size Change: +534 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
- return coupon errors in a property - don't throw from coupon validation: - return info about errors to route handler - tweak logic in route handler to prevent subsequent processing - default payment result to fail to avoid accidental successful checkout - in client, catch errors and new customer id: - render any errors as notices - i.e. coupon error - if a customer ID is included, push into store (so UI updates)
- reinstate thrown exception when validating order - return exception was an experiment, now solved in #3454
…response: - update store with new user id - remove stale response.errors handling; - current approach (#3454) is to add data to error response
mikejolley
force-pushed
the
fix/checkout-handle-ajax-login-change
branch
from
b6a1d86
to
0d1f403
Compare
|
This PR introduced a snack bar notice and "errors" array in responses (unused?). I'm removing this code so as not to block it being merged. So long as we ensure nonces and user IDs are updated in the client, the checkout can react to these changes accordingly. |
There was a problem hiding this comment.
I've removed the code that wasn't needed and swapped the user_id in body for the new header. Tested with a coupon that failed after account creation and it showed the notice, updated the checkout view (hiding the account signup box), and updated nonces. Resubmission worked as normal.
* refactor and reorder checkout processing * improve handling of checkout POST with mixed success: - return coupon errors in a property - don't throw from coupon validation: - return info about errors to route handler - tweak logic in route handler to prevent subsequent processing - default payment result to fail to avoid accidental successful checkout - in client, catch errors and new customer id: - render any errors as notices - i.e. coupon error - if a customer ID is included, push into store (so UI updates) * fix linter whitespace issue from rebase merge * fix MIA order validation/errors (due to rebase): - reinstate thrown exception when validating order - return exception was an experiment, now solved in #3454 * hide "Create account" checkbox if account is created during an error response: - update store with new user id - remove stale response.errors handling; - current approach (#3454) is to add data to error response * show a notice informing user that they have signed up * white space * Handle header and update typedef * Remove "errors" schema * remove errors Co-authored-by: Mike Jolley <mike.jolley@me.com>
Related #3363 #3423
The checkout API can sometimes create a new user account and log that user in – the
Create an account?option.If there are other errors that prevent checkout from succeeding (e.g. invalid coupon - see #3363), this can leave the checkout in a slightly broken state. The core of the issue is that the checkout block and state isn't updated to reflect the fact that the user is logged in. Also the API response includes a stale nonce, because the nonce is generated early in request handling, before account creation.
The goal of this PR is to fix these issues, and generally make the checkout UX robust to user login each time the checkout is submitted (i.e. after any AJAX request).
Create an account?checkbox if user is now logged in.This PR is currently based off #3454. They are closely related; this PR depends on the updated nonce from #3454 when a new account is created. When #3454 is merged, this should be rebased to trunk (and retested).
How to test the changes in this Pull Request:
*@legit.com.try@sneaky.comCreate an account?option and complete checkout fields.Create an accountcheckbox is gone + notice."New account" notice
Note - I couldn't get a regular notice working, it seems to only display one at a time. Snackbar style works, and maybe is a good fit for this notice. @LevinMedia can you review this notice UX and wording and advise? I don't think the notice is essential (could be handled as an improvement later), so we could back out of this if needed.
Here are some ideas for wording for the notice:
Congratulations! You have signed up for a user account.Welcome! Your user account has been created.Screenshot walkthrough
Changelog