This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
add fallback screen reader styles #3557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haszari
requested review from
mikejolley and
Aljullu
and removed request for
a team
|
Size Change: +413 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
Aljullu
approved these changes
Dec 16, 2020
There was a problem hiding this comment.
I've tested with Safari VoiceOver but I couldn't focus the element in normal use. Keen for some testing of this with various browsers/platforms and screen reader tech :)
If you were using the Tab key, I think that's to be expected. Screen readers usually provide a different navigation method which is more "line-by-line" so you can navigate to non-focusable items. With Orca it's done with the arrow keys, I guess it's probably the same in other screen readers?
I tested removing the screen-reader-text styles from Storefront and I can confirm this PR adds a fallback so screen reader elements are hidden.
In order to test :focus styles, I converted the <FormStep> legend element into an a and it looked great:
My only concern is that we are introducing a new set of 'screen-reader' styles, which differs from the ones in other projects:
Not blocking merge, but do you think we could use one of those 👆 as the base instead of introducing a new one from underscores? 🙂
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
- tweak mixin to align with focus-reveal style - add new mixin for focus-reveal style, since it is coupled to visually-hidden mixin
Good thinking @Aljullu , I should have looked more carefully for prior art! I've switched to using our (most local) |
Aljullu
approved these changes
Dec 17, 2020
senadir
added
focus: accessibility
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3265
This PR adds styling for screen-reader text elements. Usually this is handled by the theme. However if the theme doesn't have support the screen reader text may be rendered inline (which is not intended); these fallback styles ensure screen reader text is hidden by default, and provides
:focusstyles for when the text has focus and is being read.The specifics of the styles are pasted direct from underscores, with some colours changed. Feedback welcome on how to generalise these so they are a minimal, safe fallback (i.e. should not be opinionated).
Accessibility
prefers-reduced-motionI've tested with Safari VoiceOver but I couldn't focus the element in normal use. Keen for some testing of this with various browsers/platforms and screen reader tech :)
Screenshots
Focused in chrome and safari:
Notes:
:focususing browser dev tools.For comparison, here's a screenshot of the issue:
How to test the changes in this Pull Request:
Bad Themeusing Underscores and deleted the screen reader styles..screen-reader-textis hidden by default and is helpful when using a screen reader.Changelog