Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Fix isDefault on Buttons and switch Toolbar with ToolbarGroup #3577

Merged
merged 2 commits into from Dec 21, 2020
Merged

Fix isDefault on Buttons and switch Toolbar with ToolbarGroup #3577

merged 2 commits into from Dec 21, 2020

Conversation

senadir
Copy link
Member

@senadir senadir commented Dec 21, 2020 •
edited

This PR fixes all isDefault and Toolbar warnings, I did a regex global replace for Toolbar and manually searched and replaced isDefault, it touches a lot of files but everything should be caught by our E2E.

Fixes #3487
Fixes #3485
Fixes #3481
Fixes #3479
Fixes #3475
Fixes #3510
Fixes #3438

How to test the changes in this Pull Request:

Smoke test the following blocks

  • any atomic block settings.
  • attributes filter
  • featured category
  • featured product
  • handpicked products
  • product category
  • product tag
  • products by attribute
  • all products
  • all reviews
  • single product

Changelog

Fix console warnings in WordPress 5.6

@senadir senadir requested a review from a team as a code owner December 21, 2020 14:12
@senadir senadir requested review from haszari and removed request for a team December 21, 2020 14:12
@github-actions
Copy link
Contributor

Size Change: +84 B (0%)

Total Size: 1.16 MB

Filename Size Change
build/active-filters.js 8.94 kB +3 B (0%)
build/all-products.js 36.4 kB +12 B (0%)
build/all-reviews.js 9.89 kB +5 B (0%)
build/attribute-filter.js 12.5 kB +6 B (0%)
build/checkout-frontend.js 92.5 kB +8 B (0%)
build/checkout.js 43.2 kB +5 B (0%)
build/featured-category.js 7.87 kB +5 B (0%)
build/featured-product.js 10.1 kB +5 B (0%)
build/handpicked-products.js 7.5 kB +4 B (0%)
build/price-filter.js 10.4 kB +1 B (0%)
build/product-categories.js 3.23 kB +2 B (0%)
build/product-category.js 8.52 kB +4 B (0%)
build/product-tag.js 6.58 kB +4 B (0%)
build/products-by-attribute.js 8.49 kB +4 B (0%)
build/reviews-by-category.js 11.9 kB +5 B (0%)
build/reviews-by-product.js 13.5 kB +6 B (0%)
build/single-product.js 10.3 kB +5 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/active-filters-frontend.js 8.75 kB 0 B
build/all-products-frontend.js 34.7 kB 0 B
build/atomic-block-components/add-to-cart--atomic-block-components/button.js 3.29 kB 0 B
build/atomic-block-components/add-to-cart--atomic-block-components/image--atomic-block-components/title.js 335 B 0 B
build/atomic-block-components/add-to-cart-frontend.js 9.02 kB 0 B
build/atomic-block-components/add-to-cart.js 7.54 kB 0 B
build/atomic-block-components/button-frontend.js 2.31 kB 0 B
build/atomic-block-components/button.js 839 B 0 B
build/atomic-block-components/category-list-frontend.js 468 B 0 B
build/atomic-block-components/category-list.js 475 B 0 B
build/atomic-block-components/image-frontend.js 1.68 kB 0 B
build/atomic-block-components/image.js 1.13 kB 0 B
build/atomic-block-components/price-frontend.js 2.28 kB 0 B
build/atomic-block-components/price.js 2.31 kB 0 B
build/atomic-block-components/rating-frontend.js 523 B 0 B
build/atomic-block-components/rating.js 529 B 0 B
build/atomic-block-components/sale-badge-frontend.js 858 B 0 B
build/atomic-block-components/sale-badge.js 864 B 0 B
build/atomic-block-components/sku-frontend.js 388 B 0 B
build/atomic-block-components/sku.js 393 B 0 B
build/atomic-block-components/stock-indicator-frontend.js 567 B 0 B
build/atomic-block-components/stock-indicator.js 572 B 0 B
build/atomic-block-components/summary-frontend.js 918 B 0 B
build/atomic-block-components/summary.js 926 B 0 B
build/atomic-block-components/tag-list-frontend.js 465 B 0 B
build/atomic-block-components/tag-list.js 471 B 0 B
build/atomic-block-components/title-frontend.js 1.35 kB 0 B
build/atomic-block-components/title.js 1.21 kB 0 B
build/attribute-filter-frontend.js 18.1 kB 0 B
build/blocks.js 3.49 kB 0 B
build/cart-frontend.js 77.4 kB 0 B
build/cart.js 40.9 kB 0 B
build/editor-rtl.css 14.9 kB 0 B
build/editor.css 14.9 kB 0 B
build/price-filter-frontend.js 14.9 kB 0 B
build/product-best-sellers.js 7.57 kB 0 B
build/product-new.js 7.75 kB 0 B
build/product-on-sale.js 8.14 kB 0 B
build/product-search.js 3.55 kB 0 B
build/product-top-rated.js 7.72 kB 0 B
build/reviews-frontend.js 9.5 kB 0 B
build/single-product-frontend.js 37.9 kB 0 B
build/style-rtl.css 18.6 kB 0 B
build/style.css 18.6 kB 0 B
build/vendors--atomic-block-components/price-frontend.js 5.65 kB 0 B
build/vendors-style-rtl.css 1.05 kB 0 B
build/vendors-style.css 1.05 kB 0 B
build/vendors.js 434 kB 0 B
build/wc-blocks-data.js 6.89 kB 0 B
build/wc-blocks-middleware.js 931 B 0 B
build/wc-blocks-registry.js 2.39 kB 0 B
build/wc-payment-method-bacs.js 775 B 0 B
build/wc-payment-method-cheque.js 771 B 0 B
build/wc-payment-method-cod.js 866 B 0 B
build/wc-payment-method-paypal.js 813 B 0 B
build/wc-payment-method-stripe.js 12.1 kB 0 B
build/wc-settings.js 2.6 kB 0 B
build/wc-shared-context.js 1.53 kB 0 B
build/wc-shared-hocs.js 1.66 kB 0 B

compressed-size-action

@senadir senadir self-assigned this Dec 21, 2020
@senadir senadir added block: all products Issues related to the all products block. block: all reviews Issues related to the All Reviews block. block: featured category Issues related to the Featured Category block, block: featured product Issues related to the Featured Product block. block: filter by attribute Issues related to the Filter by Attribute block. block: hand-picked products Issues related to the Hand-picked Products block. block: single product Issues related to the single product block. block: products by category Issues related to the Products by Category block. block: products by tag Issues related to the Products by Tag block. block: products by attribute Issues related to the Products by Attribute block. 🔹 block-type: atomic blocks labels Dec 21, 2020
@senadir senadir added this to the 4.1.0 milestone Dec 21, 2020
Aljullu
Aljullu approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@Aljullu Aljullu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick test with all block in the editor screen and everything was looking fine and there were no warnings in the console.

@senadir senadir merged commit 01649ae into trunk Dec 21, 2020
@senadir senadir deleted the fix/isDefault-to-isSecondary branch December 21, 2020 16:03
@github-actions github-actions bot mentioned this pull request Apr 1, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Aljullu Aljullu Aljullu approved these changes

@haszari haszari Awaiting requested review from haszari

Assignees

@senadir senadir

Labels
block: all products Issues related to the all products block. block: all reviews Issues related to the All Reviews block. block: featured category Issues related to the Featured Category block, block: featured product Issues related to the Featured Product block. block: filter by attribute Issues related to the Filter by Attribute block. block: hand-picked products Issues related to the Hand-picked Products block. block: products by attribute Issues related to the Products by Attribute block. block: products by category Issues related to the Products by Category block. block: products by tag Issues related to the Products by Tag block. block: single product Issues related to the single product block. type: compatibility
Projects
None yet
Milestone
4.1.0
2 participants
@senadir @Aljullu