Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Fix direct call to setAttribute in EditProductSearch body #3578

Merged
merged 1 commit into from Dec 21, 2020

Conversation

senadir
Copy link
Member

@senadir senadir commented Dec 21, 2020

Product Search called setAttribute directly on body, while this might work, it would cause other issues down the road and emits a console error.
All state changes should be called in an event callback or inside useEffect.

Fixes #3486

How to test the changes in this Pull Request:

  1. Insert Product Search
  2. You would not see any issues

Changelog

Fix bug inside Product Search in the editor.

@senadir senadir added type: bug The issue/PR concerns a confirmed bug. block: product search Issues related to the Product Search block. labels Dec 21, 2020
@senadir senadir added this to the 4.1.0 milestone Dec 21, 2020
@senadir senadir self-assigned this Dec 21, 2020
@senadir senadir requested a review from a team as a code owner December 21, 2020 14:47
@senadir senadir requested review from budzanowski and removed request for a team December 21, 2020 14:47
@github-actions
Copy link
Contributor

Size Change: +19 B (0%)

Total Size: 1.16 MB

Filename Size Change
build/product-search.js 3.57 kB +19 B (+1%)
ℹ️ View Unchanged
Filename Size Change
build/active-filters-frontend.js 8.75 kB 0 B
build/active-filters.js 8.94 kB 0 B
build/all-products-frontend.js 34.7 kB 0 B
build/all-products.js 36.4 kB 0 B
build/all-reviews.js 9.88 kB 0 B
build/atomic-block-components/add-to-cart--atomic-block-components/button.js 3.29 kB 0 B
build/atomic-block-components/add-to-cart--atomic-block-components/image--atomic-block-components/title.js 335 B 0 B
build/atomic-block-components/add-to-cart-frontend.js 9.02 kB 0 B
build/atomic-block-components/add-to-cart.js 7.54 kB 0 B
build/atomic-block-components/button-frontend.js 2.31 kB 0 B
build/atomic-block-components/button.js 839 B 0 B
build/atomic-block-components/category-list-frontend.js 468 B 0 B
build/atomic-block-components/category-list.js 475 B 0 B
build/atomic-block-components/image-frontend.js 1.68 kB 0 B
build/atomic-block-components/image.js 1.13 kB 0 B
build/atomic-block-components/price-frontend.js 2.28 kB 0 B
build/atomic-block-components/price.js 2.31 kB 0 B
build/atomic-block-components/rating-frontend.js 523 B 0 B
build/atomic-block-components/rating.js 529 B 0 B
build/atomic-block-components/sale-badge-frontend.js 858 B 0 B
build/atomic-block-components/sale-badge.js 864 B 0 B
build/atomic-block-components/sku-frontend.js 388 B 0 B
build/atomic-block-components/sku.js 393 B 0 B
build/atomic-block-components/stock-indicator-frontend.js 567 B 0 B
build/atomic-block-components/stock-indicator.js 572 B 0 B
build/atomic-block-components/summary-frontend.js 918 B 0 B
build/atomic-block-components/summary.js 926 B 0 B
build/atomic-block-components/tag-list-frontend.js 465 B 0 B
build/atomic-block-components/tag-list.js 471 B 0 B
build/atomic-block-components/title-frontend.js 1.35 kB 0 B
build/atomic-block-components/title.js 1.21 kB 0 B
build/attribute-filter-frontend.js 18.1 kB 0 B
build/attribute-filter.js 12.5 kB 0 B
build/blocks.js 3.49 kB 0 B
build/cart-frontend.js 77.4 kB 0 B
build/cart.js 40.9 kB 0 B
build/checkout-frontend.js 92.5 kB 0 B
build/checkout.js 43.2 kB 0 B
build/editor-rtl.css 14.9 kB 0 B
build/editor.css 14.9 kB 0 B
build/featured-category.js 7.87 kB 0 B
build/featured-product.js 10.1 kB 0 B
build/handpicked-products.js 7.5 kB 0 B
build/price-filter-frontend.js 14.9 kB 0 B
build/price-filter.js 10.4 kB 0 B
build/product-best-sellers.js 7.57 kB 0 B
build/product-categories.js 3.23 kB 0 B
build/product-category.js 8.52 kB 0 B
build/product-new.js 7.75 kB 0 B
build/product-on-sale.js 8.14 kB 0 B
build/product-tag.js 6.57 kB 0 B
build/product-top-rated.js 7.72 kB 0 B
build/products-by-attribute.js 8.49 kB 0 B
build/reviews-by-category.js 11.9 kB 0 B
build/reviews-by-product.js 13.5 kB 0 B
build/reviews-frontend.js 9.5 kB 0 B
build/single-product-frontend.js 37.9 kB 0 B
build/single-product.js 10.3 kB 0 B
build/style-rtl.css 18.6 kB 0 B
build/style.css 18.6 kB 0 B
build/vendors--atomic-block-components/price-frontend.js 5.65 kB 0 B
build/vendors-style-rtl.css 1.05 kB 0 B
build/vendors-style.css 1.05 kB 0 B
build/vendors.js 434 kB 0 B
build/wc-blocks-data.js 6.89 kB 0 B
build/wc-blocks-middleware.js 931 B 0 B
build/wc-blocks-registry.js 2.39 kB 0 B
build/wc-payment-method-bacs.js 775 B 0 B
build/wc-payment-method-cheque.js 771 B 0 B
build/wc-payment-method-cod.js 866 B 0 B
build/wc-payment-method-paypal.js 813 B 0 B
build/wc-payment-method-stripe.js 12.1 kB 0 B
build/wc-settings.js 2.6 kB 0 B
build/wc-shared-context.js 1.53 kB 0 B
build/wc-shared-hocs.js 1.66 kB 0 B

compressed-size-action

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: product search Issues related to the Product Search block. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WP 5.6 - Product Search
2 participants