This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Honor hidden property of cart item data and add support for experimenal property #3732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
status: needs review
category: extensibility
|
Size Change: -3.77 kB (0%) Total Size: 1.18 MB
ℹ️ View Unchanged
|
opr
approved these changes
Jan 26, 2021
| @@ -12,6 +12,8 @@ import './style.scss'; | |||
|
|
|||
| // Component to display cart item data and variations. | |||
| const ProductDetails = ( { details = [] } ) => { | |||
| details = details.filter( ( detail ) => ! detail.hidden ); | |||
There was a problem hiding this comment.
Are we worried about checking if details is arraylike here? I know it defaults to one, but what if a non-arraylike is passed in?
There was a problem hiding this comment.
Good point. I also took the chance to add snapshot testing.
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so:
hiddenproperty set to true, it will be hidden.hiddencan be overridden with the__experimental_woocommerce_blocks_hiddenproperty, which only has effect in blocks.Screenshots
How to test the changes in this Pull Request:
fix/details-disappearingbranch in WC Subscriptions (see relevant PR: 3968-gh-woocommerce/woocommerce-subscriptions).Changelog