Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Inherit line height in Cart item total #3897

Merged
merged 1 commit into from Mar 5, 2021
Merged

Conversation

opr
Copy link
Contributor

@opr opr commented Mar 1, 2021

This PR will change the line height of the price and sale badge (and any other items that may appear in the total column of a Cart line item). Previously, this line height being set was causing the sale badge in this column to appear differently to the sale badge under the product name.

Screenshots

Before

image

After

image

How to test the changes in this Pull Request:

  1. Add an item that's on sale to your cart then go to the cart block. Increase its quantity to 2 or more.
  2. Verify the sale badges are the same height.
  3. Try this with a subscription product and our branch of subscriptions checked out. The text in the sales badges will be longer but should still display well.
  4. Try this in other themes to ensure the badges display the same in them.

Changelog

Ensure sale badges have a uniform height in the Cart block.

@opr opr added status: needs review type: bug The issue/PR concerns a confirmed bug. focus: blocks Specific work involving or impacting how blocks behave. block: cart Issues related to the cart block. focus: global styles Issues that involve styles/css/layout structure. labels Mar 1, 2021
@opr opr added this to the 4.6.0 milestone Mar 1, 2021
@opr opr self-assigned this Mar 1, 2021
@opr opr requested a review from a team as a code owner March 1, 2021 11:40
@opr opr requested review from senadir and removed request for a team March 1, 2021 11:40
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2021

Size Change: -4 B (0%)

Total Size: 1.15 MB

Filename Size Change
build/style-rtl.css 18.9 kB -2 B (0%)
build/style.css 18.9 kB -2 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/active-filters-frontend.js 8.38 kB 0 B
build/active-filters.js 8.5 kB 0 B
build/all-products-frontend.js 34.6 kB 0 B
build/all-products.js 36.4 kB 0 B
build/all-reviews.js 9.89 kB 0 B
build/atomic-block-components/add-to-cart--atomic-block-components/button.js 3.37 kB 0 B
build/atomic-block-components/add-to-cart--atomic-block-components/image--atomic-block-components/title.js 334 B 0 B
build/atomic-block-components/add-to-cart-frontend.js 9.19 kB 0 B
build/atomic-block-components/add-to-cart.js 7.68 kB 0 B
build/atomic-block-components/button-frontend.js 2.37 kB 0 B
build/atomic-block-components/button.js 839 B 0 B
build/atomic-block-components/category-list-frontend.js 469 B 0 B
build/atomic-block-components/category-list.js 476 B 0 B
build/atomic-block-components/image-frontend.js 1.77 kB 0 B
build/atomic-block-components/image.js 1.23 kB 0 B
build/atomic-block-components/price-frontend.js 1.94 kB 0 B
build/atomic-block-components/price.js 1.97 kB 0 B
build/atomic-block-components/rating-frontend.js 521 B 0 B
build/atomic-block-components/rating.js 526 B 0 B
build/atomic-block-components/sale-badge-frontend.js 861 B 0 B
build/atomic-block-components/sale-badge.js 871 B 0 B
build/atomic-block-components/sku-frontend.js 390 B 0 B
build/atomic-block-components/sku.js 394 B 0 B
build/atomic-block-components/stock-indicator-frontend.js 570 B 0 B
build/atomic-block-components/stock-indicator.js 573 B 0 B
build/atomic-block-components/summary-frontend.js 920 B 0 B
build/atomic-block-components/summary.js 925 B 0 B
build/atomic-block-components/tag-list-frontend.js 467 B 0 B
build/atomic-block-components/tag-list.js 473 B 0 B
build/atomic-block-components/title-frontend.js 1.35 kB 0 B
build/atomic-block-components/title.js 1.21 kB 0 B
build/attribute-filter-frontend.js 18.3 kB 0 B
build/attribute-filter.js 12.5 kB 0 B
build/blocks-checkout.js 16.7 kB 0 B
build/blocks.js 3.5 kB 0 B
build/cart-frontend.js 75.6 kB 0 B
build/cart.js 38.5 kB 0 B
build/checkout-frontend.js 80.3 kB 0 B
build/checkout.js 41.3 kB 0 B
build/editor-rtl.css 14.9 kB 0 B
build/editor.css 14.9 kB 0 B
build/featured-category.js 7.83 kB 0 B
build/featured-product.js 10.1 kB 0 B
build/handpicked-products.js 7.51 kB 0 B
build/price-filter-frontend.js 14.6 kB 0 B
build/price-filter.js 9.95 kB 0 B
build/price-format.js 1.37 kB 0 B
build/product-best-sellers.js 7.58 kB 0 B
build/product-categories.js 3.24 kB 0 B
build/product-category.js 8.53 kB 0 B
build/product-new.js 7.75 kB 0 B
build/product-on-sale.js 8.15 kB 0 B
build/product-search.js 3.58 kB 0 B
build/product-tag.js 6.58 kB 0 B
build/product-top-rated.js 7.72 kB 0 B
build/products-by-attribute.js 8.51 kB 0 B
build/reviews-by-category.js 12 kB 0 B
build/reviews-by-product.js 13.5 kB 0 B
build/reviews-frontend.js 9.58 kB 0 B
build/single-product-frontend.js 37.7 kB 0 B
build/single-product.js 10.3 kB 0 B
build/vendors--atomic-block-components/price-frontend.js 6.54 kB 0 B
build/vendors-style-rtl.css 1.05 kB 0 B
build/vendors-style.css 1.05 kB 0 B
build/vendors.js 418 kB 0 B
build/wc-blocks-data.js 7.2 kB 0 B
build/wc-blocks-middleware.js 1.11 kB 0 B
build/wc-blocks-registry.js 2.69 kB 0 B
build/wc-payment-method-bacs.js 820 B 0 B
build/wc-payment-method-cheque.js 816 B 0 B
build/wc-payment-method-cod.js 913 B 0 B
build/wc-payment-method-paypal.js 853 B 0 B
build/wc-payment-method-stripe.js 12.2 kB 0 B
build/wc-settings.js 2.43 kB 0 B
build/wc-shared-context.js 1.53 kB 0 B
build/wc-shared-hocs.js 1.71 kB 0 B

compressed-size-action

@nerrad nerrad modified the milestones: 4.6.0, 4.7.0 Mar 1, 2021
Copy link
Member

@mikejolley mikejolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@mikejolley mikejolley merged commit 06070c4 into trunk Mar 5, 2021
@mikejolley mikejolley deleted the fix/item-price-line-height branch March 5, 2021 14:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: cart Issues related to the cart block. focus: blocks Specific work involving or impacting how blocks behave. focus: global styles Issues that involve styles/css/layout structure. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants