This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Only set wp-edit-post style dependency if it has already been enqueued #3898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
changed the title
Remove fix to load our stylesheets after editor CSS. See ...Remove fix to load our stylesheets after editor CSS. See #3068 for the rationale of this fix. It should be no longer github.com/WordPress/gutenberg/issues/20797). https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/0937b9b65197acc8403c3ca19ece7accd3e7dedd/src/Assets.php#L79-L92🚀 This comment was generated by the automations bot based on a
|
|
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
Aljullu
added
status: needs review
type: bug
Aljullu
force-pushed
the
fix/3626-dont-load-edit-post-styles-in-fse
branch
from
0937b9b
to
3559ab0
Compare
7 tasks
mikejolley
approved these changes
Mar 2, 2021
There was a problem hiding this comment.
This fixes the issue it seems, but is broken until WordPress/gutenberg#29473 is merged.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3626.
In #3219 we marked the Gutenberg post editor CSS as a dependency of our styles in the editor, that allowed us to print our styles after theirs to fix some specificity issues. That broken FSE, because the post editor CSS is not loaded when editing the templates.
This PR fixes that making so
wp-edit-postis only marked as a dependency is it has already been enqueued.How to test the changes in this Pull Request:
Test for no regressions:
Changelog