This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Avoid get_billing and get_shipping method when updating the order #4013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
Aljullu
approved these changes
Mar 31, 2021
There was a problem hiding this comment.
Great investigation with this issue @mikejolley! I tested and I was no longer able to reproduce the issue, code changes look good as well.
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
ralucaStan
added
block: checkout
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a core bug where the
get_shippingandget_billingmethods only return changes. This means when we go to update the order, some fields are missing which leads to the issue described in #3975See woocommerce/woocommerce#29538
This PR works around the issue by avoiding these methods and just using individual setters from the customer object.
Fixes #3975
@nerrad @ralucaStan this should be merged before 4.8 IMO.
How to test the changes in this Pull Request:
See instructions in #3975.
Smoke test checkout taking care that addresses are saved correctly to the order.
Changelog