This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejolley
added
type: enhancement
The issue is a request for an enhancement.
needs: dev note
PR that has some text that needs to be included in the release notes.
type: compatibility
labels
Mar 31, 2021
mikejolley
requested review from
senadir and
nerrad
and removed request for
a team and
senadir
March 31, 2021 14:56
nerrad
approved these changes
Mar 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
I just noticed when looking through the files as a part of this feature unveiling that it doesn't appear any of the new experimental hook slugs are in this doc. It'll be especially important to include them in this doc given the prefix differs from what the doc references (so followup searches in the future won't surface them). Up to you whether you do that in this PR (preferable) or in a followup (if so asap), but I think we should get that doc updated? |
mikejolley
force-pushed
the
update/ga-extension-integration
branch
from
April 6, 2021 11:18
422da86
to
a8b60e5
Compare
Size Change: 0 B Total Size: 1.17 MB ℹ️ View Unchanged
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
needs: dev note
PR that has some text that needs to be included in the release notes.
type: compatibility
type: enhancement
The issue is a request for an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the experimental flag from the GA extension code. If using the GA extension, block events will also be tracked.
Closes #3175
Changelog
Dev note
Blocks are now compatible with the Google Analytics Integration: https://woocommerce.com/products/woocommerce-google-analytics/ If using Google Analytics with GTAG support (and a
G-
prefixed site ID), block events will also be tracked. This includes: