Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Stop shipping package titles breaking in the middle of a word #4049

Merged
merged 1 commit into from Apr 9, 2021

Conversation

opr
Copy link
Contributor

@opr opr commented Apr 8, 2021

This is a simple fix to stop the titles of items in the sidebar of the checkout (rendered by the Title component) breaking in the middle of a word.

(You will need to check out 4059-gh-woocommerce/woocommerce-subscription or the feature/checkout-block-simple-multiple-subscriptions branch if 4059 is merged before this PR is reviewed)

Screenshots

Before

After

How to test the changes in this Pull Request:

  1. Add a subscription product with a recurring shipment
  2. Go to the checkout and ensure the title is split onto two lines if necessary and that the break is between a word, not in the middle of one.

Changelog

Stop shipping package titles line-breaks occurring in the middle of a word.

@opr opr added type: bug The issue/PR concerns a confirmed bug. block: checkout Issues related to the checkout block. focus: global styles Issues that involve styles/css/layout structure. labels Apr 8, 2021
@opr opr added this to the 4.9.0 milestone Apr 8, 2021
@opr opr self-assigned this Apr 8, 2021
@opr opr requested a review from a team as a code owner April 8, 2021 12:56
@opr opr requested review from mikejolley and removed request for a team April 8, 2021 12:56
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2021

Size Change: +12 B (0%)

Total Size: 1.16 MB

Filename Size Change
build/style-rtl.css 18.4 kB +6 B (0%)
build/style.css 18.4 kB +6 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/active-filters-frontend.js 8.63 kB 0 B
build/active-filters.js 8.7 kB 0 B
build/all-products-frontend.js 35.6 kB 0 B
build/all-products.js 36.9 kB 0 B
build/all-reviews.js 9.92 kB 0 B
build/atomic-block-components/add-to-cart--atomic-block-components/button--atomic-block-components/image---a7e2bb9b.js 1.8 kB 0 B
build/atomic-block-components/add-to-cart--atomic-block-components/button.js 2.21 kB 0 B
build/atomic-block-components/add-to-cart--atomic-block-components/image--atomic-block-components/title.js 335 B 0 B
build/atomic-block-components/add-to-cart-frontend.js 9.01 kB 0 B
build/atomic-block-components/add-to-cart.js 7.84 kB 0 B
build/atomic-block-components/button-frontend.js 2.02 kB 0 B
build/atomic-block-components/button.js 896 B 0 B
build/atomic-block-components/category-list-frontend.js 469 B 0 B
build/atomic-block-components/category-list.js 477 B 0 B
build/atomic-block-components/image-frontend.js 1.82 kB 0 B
build/atomic-block-components/image.js 1.29 kB 0 B
build/atomic-block-components/price-frontend.js 1.98 kB 0 B
build/atomic-block-components/price.js 2 kB 0 B
build/atomic-block-components/rating-frontend.js 521 B 0 B
build/atomic-block-components/rating.js 524 B 0 B
build/atomic-block-components/sale-badge-frontend.js 861 B 0 B
build/atomic-block-components/sale-badge.js 868 B 0 B
build/atomic-block-components/sku-frontend.js 391 B 0 B
build/atomic-block-components/sku.js 394 B 0 B
build/atomic-block-components/stock-indicator-frontend.js 570 B 0 B
build/atomic-block-components/stock-indicator.js 572 B 0 B
build/atomic-block-components/summary-frontend.js 918 B 0 B
build/atomic-block-components/summary.js 925 B 0 B
build/atomic-block-components/tag-list-frontend.js 465 B 0 B
build/atomic-block-components/tag-list.js 472 B 0 B
build/atomic-block-components/title-frontend.js 1.41 kB 0 B
build/atomic-block-components/title.js 1.26 kB 0 B
build/attribute-filter-frontend.js 18.4 kB 0 B
build/attribute-filter.js 12.5 kB 0 B
build/blocks-checkout.js 13.7 kB 0 B
build/blocks.js 3.49 kB 0 B
build/cart-frontend.js 77.7 kB 0 B
build/cart.js 43.6 kB 0 B
build/checkout-frontend.js 82 kB 0 B
build/checkout.js 45.8 kB 0 B
build/editor-rtl.css 14.9 kB 0 B
build/editor.css 14.9 kB 0 B
build/featured-category.js 7.87 kB 0 B
build/featured-product.js 10.1 kB 0 B
build/handpicked-products.js 6.5 kB 0 B
build/price-filter-frontend.js 14.8 kB 0 B
build/price-filter.js 10 kB 0 B
build/price-format.js 1.46 kB 0 B
build/product-best-sellers.js 6.59 kB 0 B
build/product-categories.js 3.23 kB 0 B
build/product-category.js 7.57 kB 0 B
build/product-new.js 6.76 kB 0 B
build/product-on-sale.js 7.17 kB 0 B
build/product-search.js 3.6 kB 0 B
build/product-tag.js 6.61 kB 0 B
build/product-top-rated.js 6.73 kB 0 B
build/products-by-attribute.js 7.51 kB 0 B
build/reviews-by-category.js 12 kB 0 B
build/reviews-by-product.js 13.5 kB 0 B
build/reviews-frontend.js 9.59 kB 0 B
build/single-product-frontend.js 38.7 kB 0 B
build/single-product.js 10.3 kB 0 B
build/vendors--atomic-block-components/price-frontend.js 6.54 kB 0 B
build/vendors-style-rtl.css 1.05 kB 0 B
build/vendors-style.css 1.05 kB 0 B
build/vendors.js 419 kB 0 B
build/wc-blocks-data.js 7.35 kB 0 B
build/wc-blocks-google-analytics.js 1.99 kB 0 B
build/wc-blocks-middleware.js 1.32 kB 0 B
build/wc-blocks-registry.js 2.75 kB 0 B
build/wc-payment-method-bacs.js 812 B 0 B
build/wc-payment-method-cheque.js 807 B 0 B
build/wc-payment-method-cod.js 903 B 0 B
build/wc-payment-method-paypal.js 844 B 0 B
build/wc-payment-method-stripe.js 12.3 kB 0 B
build/wc-settings.js 2.83 kB 0 B
build/wc-shared-context.js 1.54 kB 0 B
build/wc-shared-hocs.js 1.71 kB 0 B

compressed-size-action

Copy link
Member

@mikejolley mikejolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me 🚢 👍🏻

@mikejolley mikejolley merged commit 3565ca9 into trunk Apr 9, 2021
@mikejolley mikejolley deleted the fix/shipping-title-length branch April 9, 2021 15:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: checkout Issues related to the checkout block. focus: global styles Issues that involve styles/css/layout structure. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants