This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +2.41 kB (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
mikejolley
requested review from
nerrad and
opr
and removed request for
Aljullu
April 19, 2021 15:29
nerrad
approved these changes
Apr 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only got a chance to do a review of the code and it looks good to me. I do have a question about removing validate_callback
function in favour of an inline nonce check on the response but that is non-blocking.
If needed I can run through some testing tomorrow, but I'll pre-approve based on the code review.
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Apr 19, 2021
opr
reviewed
Apr 20, 2021
Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com>
mikejolley
added
type: enhancement
The issue is a request for an enhancement.
focus: performance
The issue/PR is related to performance.
labels
Apr 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
focus: performance
The issue/PR is related to performance.
type: enhancement
The issue is a request for an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raising #3899 again.
When testing you must ensure you have reran
npm install
for the dataloader dependency.This PR implements batching in the Store API, and a dataloader class in the client to batch requests within a certain interval.
Batching works for POST, PUT, DELETE API requests. GET requests are not affected.
As well as adding the batching, this commit creates a control to handle fragment updates and adds a timeout. This prevents multiple fragment updates after a batch of events have ran.
NOTE: I am requested feedback/code review, but some things are left to do before it can be merged:
Fixes #2094
How to test the changes in this Pull Request:
Changelog