This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Update Cart Widget when adding an item in All Products #4291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senadir
added
type: bug
The issue/PR concerns a confirmed bug.
block: all products
Issues related to the all products block.
labels
May 31, 2021
Size Change: +199 B (0%) Total Size: 986 kB
ℹ️ View Unchanged
|
opr
approved these changes
Jun 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🏼 Works well, code looks fine too.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: all products
Issues related to the all products block.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4075 we refactored our data store, a new control file was created inside the
cart
store that had only one controller, which managed triggering the update fragment, we didn't import that control and so it wasn't registered, this PR fixes it.Fixes #4287
How to test the changes in this Pull Request:
Changelog