This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Block Widgets: add block transforms for legacy widgets with a block equivalent #4292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frontdevde
added
type: enhancement
The issue is a request for an enhancement.
focus: FSE
Work related to prepare WooCommerce for FSE.
labels
May 31, 2021
Size Change: +391 B (0%) Total Size: 986 kB
ℹ️ View Unchanged
|
Aljullu
reviewed
Jun 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really exciting to see the changes in this PR! One step forward to a day when all WooCommerce frontend can be powered by blocks. 🥳
I will leave the final review to @mikejolley, but I left a suggestion below:
mikejolley
approved these changes
Jun 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worked once I sorted out my environment :) Just one small item of feedback otherwise
Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com>
frontdevde
force-pushed
the
update/add-block-widget-transforms
branch
from
June 3, 2021 12:14
833707e
to
5261ba2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
focus: FSE
Work related to prepare WooCommerce for FSE.
type: enhancement
The issue is a request for an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4220
This PR aims to provide block transforms for legacy widgets that have a block equivalent.
As per the product decision outlined in #4220, the widgets we want to provide transforms for are:
Product Search, Product Categories, and Recent Product Reviews
How to test the changes in this Pull Request:
Widgets to test: Product Search, Product Categories, Recent Product Reviews
Prerequisites:
woocommerce-gutenberg-products-block
:What to test:
Changelog