This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Document and update naming of Block Asset Handles #4324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +21 B (0%) Total Size: 988 kB
ℹ️ View Unchanged
|
mikejolley
added
skip-changelog
Aljullu
approved these changes
Jun 9, 2021
There was a problem hiding this comment.
Works great and code changes look good. Nice cleanup! 👏
@mikejolley do you think this PR needs a dev note or something similar? My understanding is that it will impact any theme/plugin that relies on our script/style handles.
|
@Aljullu I'm uncertain — the scripts and styles we've changed are our own block handles (the external packages, price, and checkout, were not changed). Can you think of a use case where someone would use these handles? |
Yeah... I'm not sure. I'm thinking on a store that uses WooCommerce but none of WooCommerce Blocks, which might have unregistered our styles/scripts? Not sure if that's a case we need to account for, though, sounds very edge-case. Leaving the decision to you. |
mikejolley
added
needs: dev note
|
Added a note 👍🏻 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR establishes the pattern of naming block handles as
wc-{blockname}-block, and other scripts aswc-blocks-{script}to avoid conflicts.To help map handles -> built scripts I've also made script filenames match. I did not do this for the blocks themselves because it caused some breakage in Atomic Blocks and complicates how blocks are setup in webpack.
Closes #2660
How to test the changes in this Pull Request:
Dev Note
Some script handles have been changed in this version for consistency. It is unlikely that these handles are being used directly by 3rd parties because they are only used within the blocks, however for reference:
wc-block-vendors-style->wc-blocks-vendors-stylewc-block-editor->wc-blocks-editor-stylewc-block-style->wc-blocks-stylewc-vendors->wc-blocks-vendorswc-shared-context->wc-blocks-shared-contextwc-shared-hocs->wc-blocks-shared-hocsIn addition, all block script handles now have the
-blocksuffix.Changelog