Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Fix Product Categories List display issues in WP 5.8 #4335

Merged
merged 1 commit into from Jun 12, 2021
Merged

Fix Product Categories List display issues in WP 5.8 #4335

merged 1 commit into from Jun 12, 2021

Conversation

Aljullu
Copy link
Contributor

@Aljullu Aljullu commented Jun 9, 2021 •
edited

Fixes #4334.

How to test the changes in this Pull Request:

  1. With Gutenberg and TT1 Blocks, go to the Site Editor.
  2. Add a Product Categories List block.
  3. Set the Show category images attribute to true.
  4. Verify images have the correct size:
Before After
Screenshot of Products Categories List rendering huge images Screenshot of Products Categories List rendering images of the correct size
  1. With the same theme, add the Product Categories List block to a post or page and verify there is no bottom space between the image and the border.
Before After
Screenshot of Products Categories List images having a border offset Screenshot of Products Categories List images without the border offset

Changelog

Fix Product Categories List block display in Site Editor.

@Aljullu Aljullu added status: needs review status: blocker Used on issues or pulls that block work from being released. block: product categories list Issues related to the Product Categories List block. focus: FSE Work related to prepare WooCommerce for FSE. labels Jun 9, 2021
@Aljullu Aljullu added this to the 5.3.1 milestone Jun 9, 2021
@Aljullu Aljullu self-assigned this Jun 9, 2021
@Aljullu Aljullu requested a review from a team as a code owner June 9, 2021 14:53
@Aljullu Aljullu requested review from frontdevde and removed request for a team June 9, 2021 14:53
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2021

Size Change: +20 B (0%)

Total Size: 988 kB

Filename Size Change
build/wc-blocks-style-rtl.css 19 kB +10 B (0%)
build/wc-blocks-style.css 18.9 kB +10 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/active-filters-frontend.js 7.98 kB 0 B
build/active-filters.js 7.53 kB 0 B
build/all-products-frontend.js 34.8 kB 0 B
build/all-products.js 36.5 kB 0 B
build/all-reviews.js 9.29 kB 0 B
build/atomic-block-components/add-to-cart--atomic-block-components/button--atomic-block-components/image---a7e2bb9b.js 2.39 kB 0 B
build/atomic-block-components/add-to-cart--atomic-block-components/button.js 2 kB 0 B
build/atomic-block-components/add-to-cart--atomic-block-components/image--atomic-block-components/title.js 334 B 0 B
build/atomic-block-components/add-to-cart-frontend.js 8.75 kB 0 B
build/atomic-block-components/add-to-cart.js 7.81 kB 0 B
build/atomic-block-components/button-frontend.js 1.73 kB 0 B
build/atomic-block-components/button.js 844 B 0 B
build/atomic-block-components/category-list-frontend.js 469 B 0 B
build/atomic-block-components/category-list.js 478 B 0 B
build/atomic-block-components/image-frontend.js 1.66 kB 0 B
build/atomic-block-components/image.js 1.3 kB 0 B
build/atomic-block-components/price-frontend.js 1.98 kB 0 B
build/atomic-block-components/price.js 2.01 kB 0 B
build/atomic-block-components/rating-frontend.js 521 B 0 B
build/atomic-block-components/rating.js 525 B 0 B
build/atomic-block-components/sale-badge-frontend.js 469 B 0 B
build/atomic-block-components/sale-badge.js 475 B 0 B
build/atomic-block-components/sku-frontend.js 389 B 0 B
build/atomic-block-components/sku.js 393 B 0 B
build/atomic-block-components/stock-indicator-frontend.js 569 B 0 B
build/atomic-block-components/stock-indicator.js 572 B 0 B
build/atomic-block-components/summary-frontend.js 906 B 0 B
build/atomic-block-components/summary.js 910 B 0 B
build/atomic-block-components/tag-list-frontend.js 464 B 0 B
build/atomic-block-components/tag-list.js 472 B 0 B
build/atomic-block-components/title-frontend.js 1.41 kB 0 B
build/atomic-block-components/title.js 1.26 kB 0 B
build/attribute-filter-frontend.js 17.7 kB 0 B
build/attribute-filter.js 11.4 kB 0 B
build/blocks-checkout-editor.js 10.5 kB 0 B
build/blocks-checkout.js 19.9 kB 0 B
build/cart-frontend.js 77.9 kB 0 B
build/cart.js 44.4 kB 0 B
build/checkout-frontend.js 81.9 kB 0 B
build/checkout.js 46.6 kB 0 B
build/featured-category.js 7.23 kB 0 B
build/featured-product.js 9.4 kB 0 B
build/handpicked-products.js 5.89 kB 0 B
build/price-filter-frontend.js 14.3 kB 0 B
build/price-filter.js 9.3 kB 0 B
build/price-format.js 1.38 kB 0 B
build/product-best-sellers.js 6.12 kB 0 B
build/product-categories.js 3.38 kB 0 B
build/product-category.js 6.99 kB 0 B
build/product-new.js 6.28 kB 0 B
build/product-on-sale.js 6.62 kB 0 B
build/product-search.js 2.68 kB 0 B
build/product-tag.js 6.11 kB 0 B
build/product-top-rated.js 6.26 kB 0 B
build/products-by-attribute.js 7.22 kB 0 B
build/reviews-by-category.js 11.2 kB 0 B
build/reviews-by-product.js 12.7 kB 0 B
build/reviews-frontend.js 8.94 kB 0 B
build/single-product-frontend.js 38.1 kB 0 B
build/single-product.js 9.65 kB 0 B
build/vendors--atomic-block-components/price-frontend.js 6.54 kB 0 B
build/wc-blocks-data.js 10.9 kB 0 B
build/wc-blocks-editor-style-rtl.css 14.9 kB 0 B
build/wc-blocks-editor-style.css 14.9 kB 0 B
build/wc-blocks-google-analytics.js 1.99 kB 0 B
build/wc-blocks-middleware.js 1.48 kB 0 B
build/wc-blocks-registry.js 2.75 kB 0 B
build/wc-blocks-shared-context.js 1.54 kB 0 B
build/wc-blocks-shared-hocs.js 1.74 kB 0 B
build/wc-blocks-vendors-style-rtl.css 1.05 kB 0 B
build/wc-blocks-vendors-style.css 1.05 kB 0 B
build/wc-blocks-vendors.js 242 kB 0 B
build/wc-blocks.js 3.51 kB 0 B
build/wc-payment-method-bacs.js 812 B 0 B
build/wc-payment-method-cheque.js 807 B 0 B
build/wc-payment-method-cod.js 903 B 0 B
build/wc-payment-method-paypal.js 844 B 0 B
build/wc-payment-method-stripe.js 12.4 kB 0 B
build/wc-settings.js 2.94 kB 0 B

compressed-size-action

frontdevde
frontdevde approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@frontdevde frontdevde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested as per testing instructions and can confirm that the before/after states in both cases looked as expected i.e. I could reproduce the issue and confirm it's fixed.

LGTM 👍

@Aljullu Aljullu merged commit 944b44a into trunk Jun 12, 2021
@Aljullu Aljullu deleted the fix/product-categories-list-ep-5.8 branch June 12, 2021 09:44
Aljullu added a commit that referenced this pull request Jun 15, 2021
@Aljullu
Fix Product Categories List display issues in WP 5.8 (#4335)
7055d05
@Aljullu Aljullu mentioned this pull request Jun 15, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frontdevde frontdevde frontdevde approved these changes

Assignees

@Aljullu Aljullu

Labels
block: product categories list Issues related to the Product Categories List block. focus: FSE Work related to prepare WooCommerce for FSE. status: blocker Used on issues or pulls that block work from being released.
Projects
None yet
Milestone
5.3.1
Development

Successfully merging this pull request may close these issues.

Product Categories List: images are rendered too big in Site Editor
2 participants
@Aljullu @frontdevde