Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Switch arrow unicode characters #4364

Merged
merged 2 commits into from Jul 12, 2021
Merged

Switch arrow unicode characters #4364

merged 2 commits into from Jul 12, 2021

Conversation

mikejolley
Copy link
Member

This is a small change to make the pagination arrows match core.

Fixes #1821

Screenshots

Before:
Screenshot 2021-06-16 at 17 28 38

After:
Screenshot 2021-06-16 at 17 25 45

How to test the changes in this Pull Request:

View the pagination rendered on the all products block and confirm the symbol matches the screenshot above.

Changelog

Update pagination arrows to match core.

@mikejolley mikejolley self-assigned this Jun 16, 2021
@mikejolley mikejolley requested a review from a team as a code owner June 16, 2021 16:31
@mikejolley mikejolley requested review from ralucaStan and removed request for a team June 16, 2021 16:31
@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2021

Size Change: +107 B (0%)

Total Size: 979 kB

Filename Size Change
build/all-products-frontend.js 23.1 kB +19 B (0%)
build/all-products.js 37.3 kB +19 B (0%)
build/wc-blocks-style-rtl.css 19.3 kB +36 B (0%)
build/wc-blocks-style.css 19.3 kB +33 B (0%)
ℹ️ View Unchanged
Filename Size
build/active-filters-frontend.js 8.28 kB
build/active-filters.js 7.84 kB
build/all-reviews.js 9.56 kB
build/atomic-block-components/add-to-cart--atomic-block-components/button--atomic-block-components/image---a7e2bb9b.js 2.57 kB
build/atomic-block-components/add-to-cart--atomic-block-components/button.js 1.82 kB
build/atomic-block-components/add-to-cart--atomic-block-components/image--atomic-block-components/title.js 333 B
build/atomic-block-components/add-to-cart-frontend.js 8.64 kB
build/atomic-block-components/add-to-cart.js 7.72 kB
build/atomic-block-components/button-frontend.js 1.74 kB
build/atomic-block-components/button.js 873 B
build/atomic-block-components/category-list-frontend.js 469 B
build/atomic-block-components/category-list.js 477 B
build/atomic-block-components/image-frontend.js 1.87 kB
build/atomic-block-components/image.js 1.35 kB
build/atomic-block-components/price-frontend.js 2.08 kB
build/atomic-block-components/price.js 2.1 kB
build/atomic-block-components/rating-frontend.js 559 B
build/atomic-block-components/rating.js 566 B
build/atomic-block-components/sale-badge-frontend.js 854 B
build/atomic-block-components/sale-badge.js 866 B
build/atomic-block-components/sku-frontend.js 389 B
build/atomic-block-components/sku.js 393 B
build/atomic-block-components/stock-indicator-frontend.js 609 B
build/atomic-block-components/stock-indicator.js 610 B
build/atomic-block-components/summary-frontend.js 905 B
build/atomic-block-components/summary.js 911 B
build/atomic-block-components/tag-list-frontend.js 465 B
build/atomic-block-components/tag-list.js 471 B
build/atomic-block-components/title-frontend.js 1.44 kB
build/atomic-block-components/title.js 1.28 kB
build/attribute-filter-frontend.js 17.9 kB
build/attribute-filter.js 11.7 kB
build/blocks-checkout-editor.js 10.8 kB
build/blocks-checkout.js 20.2 kB
build/cart-frontend.js 79.2 kB
build/cart.js 45.9 kB
build/checkout-frontend.js 83.4 kB
build/checkout.js 48.2 kB
build/featured-category.js 7.39 kB
build/featured-product.js 9.55 kB
build/handpicked-products.js 6.55 kB
build/price-filter-frontend.js 14.4 kB
build/price-filter.js 9.57 kB
build/price-format.js 1.38 kB
build/product-best-sellers.js 6.73 kB
build/product-categories.js 3.38 kB
build/product-category.js 7.59 kB
build/product-new.js 6.89 kB
build/product-on-sale.js 7.23 kB
build/product-search.js 2.68 kB
build/product-tag.js 6.7 kB
build/product-top-rated.js 6.85 kB
build/products-by-attribute.js 7.82 kB
build/reviews-by-category.js 11.5 kB
build/reviews-by-product.js 13.1 kB
build/reviews-frontend.js 9.18 kB
build/single-product-frontend.js 25.8 kB
build/single-product.js 9.87 kB
build/vendors--atomic-block-components/price-frontend.js 6.51 kB
build/wc-blocks-data.js 10.9 kB
build/wc-blocks-editor-style-rtl.css 14.9 kB
build/wc-blocks-editor-style.css 14.9 kB
build/wc-blocks-google-analytics.js 1.99 kB
build/wc-blocks-middleware.js 1.48 kB
build/wc-blocks-registry.js 2.75 kB
build/wc-blocks-shared-context.js 1.54 kB
build/wc-blocks-shared-hocs.js 1.75 kB
build/wc-blocks-vendors-style-rtl.css 1.05 kB
build/wc-blocks-vendors-style.css 1.05 kB
build/wc-blocks-vendors.js 240 kB
build/wc-blocks.js 3.51 kB
build/wc-payment-method-bacs.js 812 B
build/wc-payment-method-cheque.js 807 B
build/wc-payment-method-cod.js 903 B
build/wc-payment-method-paypal.js 844 B
build/wc-payment-method-stripe.js 12.3 kB
build/wc-settings.js 2.93 kB

compressed-size-action

Copy link
Contributor

@opr opr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well! 👏🏼

@ralucaStan
Copy link
Contributor

This works as expected. I see that in Core they also handle text orientation, and display the arrows accordingly. Should we also do this, maybe open another ticket?

@mikejolley
Copy link
Member Author

Looks like this is a regression. I'm not sure how it changed the characters before when they were < >. Investigating.

@mikejolley
Copy link
Member Author

@ralucaStan I've pushed a fix for this. The <> arrows automatically flip—some feature of unicode. Arrows do not. I added CSS to flip it.

Copy link
Contributor

@ralucaStan ralucaStan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the arrow change with rtl tests out good 🚀

@mikejolley mikejolley merged commit c054cc2 into trunk Jul 12, 2021
@mikejolley mikejolley deleted the update/pagination-arrows branch July 12, 2021 11:32
@Aljullu Aljullu added this to the 5.6.0 milestone Aug 2, 2021
@Aljullu Aljullu added the type: enhancement The issue is a request for an enhancement. label Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All Products: The arrow inconsistency in the pagination section
4 participants