Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Add screen reader text to price range #4367

Merged
merged 1 commit into from Jun 23, 2021
Merged

Conversation

mikejolley
Copy link
Member

Adds screen reader text to price ranges stating: "Price between X and X".

Fixes #1669

Accessibility

How to test the changes in this Pull Request:

  1. View all products block
  2. Find a product with a price range (grouped product). e.g. Logo Collection in default content.
  3. Use voiceover or screen reader to read the price. It should announce "Price between X and X". Some tools will also read the other price but this is wrapped in aria-hidden so can be ignored.

Changelog

Add screen reader text to price ranges

@mikejolley mikejolley self-assigned this Jun 17, 2021
@mikejolley mikejolley requested a review from a team as a code owner June 17, 2021 11:50
@mikejolley mikejolley requested review from frontdevde and removed request for a team June 17, 2021 11:50
@github-actions
Copy link
Contributor

Size Change: +361 B (0%)

Total Size: 993 kB

Filename Size Change
build/active-filters.js 7.52 kB +1 B (0%)
build/all-products.js 36.7 kB +50 B (0%)
build/atomic-block-components/add-to-cart--atomic-block-components/button--atomic-block-components/image---a7e2bb9b.js 2.51 kB -1 B (0%)
build/atomic-block-components/add-to-cart--atomic-block-components/button.js 2 kB -1 B (0%)
build/atomic-block-components/add-to-cart.js 7.74 kB +2 B (0%)
build/atomic-block-components/price-frontend.js 2.05 kB +67 B (+3%)
build/atomic-block-components/price.js 2.07 kB +69 B (+3%)
build/cart-frontend.js 78.5 kB +49 B (0%)
build/cart.js 45.2 kB +47 B (0%)
build/checkout-frontend.js 82.5 kB +44 B (0%)
build/checkout.js 47.4 kB +43 B (0%)
build/featured-category.js 7.3 kB -2 B (0%)
build/featured-product.js 9.47 kB -2 B (0%)
build/handpicked-products.js 6.03 kB -1 B (0%)
build/product-best-sellers.js 6.19 kB -1 B (0%)
build/product-new.js 6.35 kB -2 B (0%)
build/product-on-sale.js 6.69 kB -2 B (0%)
build/product-tag.js 6.18 kB -2 B (0%)
build/product-top-rated.js 6.32 kB -1 B (0%)
build/products-by-attribute.js 7.29 kB -1 B (0%)
build/reviews-by-category.js 11.2 kB -1 B (0%)
build/single-product.js 9.71 kB -1 B (0%)
build/wc-blocks-vendors.js 242 kB +6 B (0%)
build/wc-blocks.js 3.51 kB +1 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/active-filters-frontend.js 8.04 kB 0 B
build/all-products-frontend.js 34.9 kB 0 B
build/all-reviews.js 9.34 kB 0 B
build/atomic-block-components/add-to-cart--atomic-block-components/image--atomic-block-components/title.js 335 B 0 B
build/atomic-block-components/add-to-cart-frontend.js 8.67 kB 0 B
build/atomic-block-components/button-frontend.js 1.73 kB 0 B
build/atomic-block-components/button.js 843 B 0 B
build/atomic-block-components/category-list-frontend.js 470 B 0 B
build/atomic-block-components/category-list.js 478 B 0 B
build/atomic-block-components/image-frontend.js 1.65 kB 0 B
build/atomic-block-components/image.js 1.31 kB 0 B
build/atomic-block-components/rating-frontend.js 520 B 0 B
build/atomic-block-components/rating.js 524 B 0 B
build/atomic-block-components/sale-badge-frontend.js 470 B 0 B
build/atomic-block-components/sale-badge.js 474 B 0 B
build/atomic-block-components/sku-frontend.js 390 B 0 B
build/atomic-block-components/sku.js 394 B 0 B
build/atomic-block-components/stock-indicator-frontend.js 568 B 0 B
build/atomic-block-components/stock-indicator.js 573 B 0 B
build/atomic-block-components/summary-frontend.js 906 B 0 B
build/atomic-block-components/summary.js 911 B 0 B
build/atomic-block-components/tag-list-frontend.js 467 B 0 B
build/atomic-block-components/tag-list.js 472 B 0 B
build/atomic-block-components/title-frontend.js 1.41 kB 0 B
build/atomic-block-components/title.js 1.26 kB 0 B
build/attribute-filter-frontend.js 17.8 kB 0 B
build/attribute-filter.js 11.4 kB 0 B
build/blocks-checkout-editor.js 10.6 kB 0 B
build/blocks-checkout.js 19.9 kB 0 B
build/price-filter-frontend.js 14.2 kB 0 B
build/price-filter.js 9.37 kB 0 B
build/price-format.js 1.38 kB 0 B
build/product-categories.js 3.39 kB 0 B
build/product-category.js 7.06 kB 0 B
build/product-search.js 2.68 kB 0 B
build/reviews-by-product.js 12.8 kB 0 B
build/reviews-frontend.js 9 kB 0 B
build/single-product-frontend.js 38.4 kB 0 B
build/vendors--atomic-block-components/price-frontend.js 6.53 kB 0 B
build/wc-blocks-data.js 10.9 kB 0 B
build/wc-blocks-editor-style-rtl.css 14.9 kB 0 B
build/wc-blocks-editor-style.css 14.9 kB 0 B
build/wc-blocks-google-analytics.js 1.99 kB 0 B
build/wc-blocks-middleware.js 1.48 kB 0 B
build/wc-blocks-registry.js 2.75 kB 0 B
build/wc-blocks-shared-context.js 1.54 kB 0 B
build/wc-blocks-shared-hocs.js 1.74 kB 0 B
build/wc-blocks-style-rtl.css 19.1 kB 0 B
build/wc-blocks-style.css 19 kB 0 B
build/wc-blocks-vendors-style-rtl.css 1.05 kB 0 B
build/wc-blocks-vendors-style.css 1.05 kB 0 B
build/wc-payment-method-bacs.js 812 B 0 B
build/wc-payment-method-cheque.js 807 B 0 B
build/wc-payment-method-cod.js 903 B 0 B
build/wc-payment-method-paypal.js 844 B 0 B
build/wc-payment-method-stripe.js 12.4 kB 0 B
build/wc-settings.js 2.94 kB 0 B

compressed-size-action

Copy link
Contributor

@opr opr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well for me! 🚢

@mikejolley mikejolley merged commit 6aa96b7 into trunk Jun 23, 2021
@mikejolley mikejolley deleted the fix/1669-price-range branch June 23, 2021 10:51
@mikejolley mikejolley added this to the 5.5.0 milestone Jun 23, 2021
@frontdevde frontdevde added the type: enhancement The issue is a request for an enhancement. label Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make price ranges accessible
3 participants