This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add TotalsWrapper component
#4415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opr
added
status: needs review
type: bug
|
Size Change: +412 B (0%) Total Size: 1 MB
ℹ️ View Unchanged
|
This is to allow TotalsWrapper to be the component responsible for handling spacing and borders.
This will be used to check if a Slot has any fills that return truthy values.
senadir
approved these changes
Jul 2, 2021
This was referenced Jul 7, 2021
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a component called
TotalsWrapperwhose purpose is to wrap components in the Cart and Checkout sidebar so that components that have borders (the grey lines between items in the screenshot section) don't have to be concerned with what follows them.For example, if the store has coupons disabled, then you could end up with a component with a bottom border, and one with a top border together resulting in a "double border".
By wrapping these components in a
TotalsWrapperthen the borders can be consistently managed from one place.The PR will also slightly change the way Slot/Fills are rendered. The
Slotwill be rendered inside aTotalsWrapperbut eachFillwill also have a border and padding applied to it (by CSS), to visually separate them.Here is an overview of the changes made in this PR:
TotalsWrappercomponent. This has the optional propslotWrapperto allow CSS to render borders onFills.hasValidFillsfunction inslot/index.js- This is to check that at least one of theFills about to be rendered is truthy (i.e. not null/undefined) or it won't render theSlot.OrderSummary,ShippingRatesControlPackage,TotalsCoupon,Cart, andCheckoutSidebarto remove borders and padding becauseTotalsWrapperis now handling it.Slots in<TotalsWrapper>Panelcomponent to only have margins/padding when the panel is open.Fixes #4267
Screenshots
How to test the changes in this Pull Request:
feature/add-inputs-for-points-redemptionon WC Points and Rewardsnpm run buildin your WC Points and Rewards directory.Changelog