This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix filtering by product type on Store API #4422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, @VoHoTv Thank you for your PR! |
Hi, sure. To reproduce the original error go to to /wp-json/wc/store/products?type=simple and you will see that the product type filter does not work and instead lists products without regard to the product type. |
senadir
changed the title
|
Thank you! works as expected, will merge after tests pass. |
frontdevde
reviewed
Jul 5, 2021
frontdevde
reviewed
Jul 5, 2021
senadir
approved these changes
Jul 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the $tax_query variable above the code where filtering happens for the product type. The reason for this change is to avoid resetting the $tax_query after a product type is specified for filtering. Which leaves you with an unfiltered product type result.