This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Ensure product grids display as intended in the editor #4424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Size Change: -26 B (0%) Total Size: 979 kB
ℹ️ View Unchanged
|
Aljullu
approved these changes
Jul 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4416
This PR fixes an issue where the product grid in all blocks it is used in displays the wrong number of columns.
The issue is caused by the generic Gutenberg reset overriding the box-sizing property value that is needed for the product grid values to be calculated correctly.
How to test the changes in this Pull Request:
Test in the editor:
Edit
the draftTest in the widget editor:
Changelog