Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Add missing class to Cart skeleton title #4498

Merged
merged 1 commit into from Jul 27, 2021

Conversation

Aljullu
Copy link
Contributor

@Aljullu Aljullu commented Jul 23, 2021

Adds a missing class to the <h2> title of the Cart skeleton so it has the same margin as the rendered block.

How to test the changes in this Pull Request:

  1. Load the Cart block and verify the margin under the Your cart title doesn't change between the rendered block and the loading skeleton.
Before After
Before After

Changelog

Remove unnecessary margin from Cart block loading skeleton to avoid content jump.

@Aljullu Aljullu added status: needs review type: bug The issue/PR concerns a confirmed bug. block: cart Issues related to the cart block. labels Jul 23, 2021
@Aljullu Aljullu self-assigned this Jul 23, 2021
@Aljullu Aljullu requested a review from a team as a code owner July 23, 2021 08:33
@Aljullu Aljullu requested review from ralucaStan and removed request for a team July 23, 2021 08:33
@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 1.06 MB

ℹ️ View Unchanged
Filename Size
build/active-filters-frontend.js 8.27 kB
build/active-filters.js 7.84 kB
build/all-products-frontend.js 23 kB
build/all-products.js 37.3 kB
build/all-reviews.js 9.6 kB
build/atomic-block-components/add-to-cart--atomic-block-components/button--atomic-block-components/image---a7e2bb9b.js 2.57 kB
build/atomic-block-components/add-to-cart--atomic-block-components/button.js 1.82 kB
build/atomic-block-components/add-to-cart--atomic-block-components/image--atomic-block-components/title.js 334 B
build/atomic-block-components/add-to-cart-frontend.js 8.65 kB
build/atomic-block-components/add-to-cart.js 7.73 kB
build/atomic-block-components/button-frontend.js 1.74 kB
build/atomic-block-components/button.js 875 B
build/atomic-block-components/category-list-frontend.js 468 B
build/atomic-block-components/category-list.js 476 B
build/atomic-block-components/image-frontend.js 1.88 kB
build/atomic-block-components/image.js 1.35 kB
build/atomic-block-components/price-frontend.js 2.09 kB
build/atomic-block-components/price.js 2.11 kB
build/atomic-block-components/rating-frontend.js 561 B
build/atomic-block-components/rating.js 568 B
build/atomic-block-components/sale-badge-frontend.js 857 B
build/atomic-block-components/sale-badge.js 867 B
build/atomic-block-components/sku-frontend.js 388 B
build/atomic-block-components/sku.js 392 B
build/atomic-block-components/stock-indicator-frontend.js 609 B
build/atomic-block-components/stock-indicator.js 612 B
build/atomic-block-components/summary-frontend.js 907 B
build/atomic-block-components/summary.js 912 B
build/atomic-block-components/tag-list-frontend.js 466 B
build/atomic-block-components/tag-list.js 470 B
build/atomic-block-components/title-frontend.js 1.43 kB
build/atomic-block-components/title.js 1.29 kB
build/attribute-filter-frontend.js 17.9 kB
build/attribute-filter.js 11.9 kB
build/blocks-checkout.js 21.2 kB
build/cart-frontend.js 77.8 kB
build/cart.js 45.6 kB
build/checkout-blocks/sample.js 174 B
build/checkout-frontend.js 82 kB
build/checkout-i2-frontend.js 51.7 kB
build/checkout-i2.js 48.4 kB
build/checkout.js 48.5 kB
build/featured-category.js 7.4 kB
build/featured-product.js 9.55 kB
build/handpicked-products.js 6.56 kB
build/price-filter-frontend.js 14.3 kB
build/price-filter.js 9.59 kB
build/price-format.js 1.37 kB
build/product-best-sellers.js 6.73 kB
build/product-categories.js 3.38 kB
build/product-category.js 7.59 kB
build/product-new.js 6.89 kB
build/product-on-sale.js 7.23 kB
build/product-search.js 2.68 kB
build/product-tag.js 6.7 kB
build/product-top-rated.js 6.85 kB
build/products-by-attribute.js 7.82 kB
build/reviews-by-category.js 11.6 kB
build/reviews-by-product.js 13.1 kB
build/reviews-frontend.js 9.22 kB
build/single-product-frontend.js 25.7 kB
build/single-product.js 9.84 kB
build/vendors--atomic-block-components/price-frontend.js 5.71 kB
build/wc-blocks-data.js 10.8 kB
build/wc-blocks-editor-style-rtl.css 15.4 kB
build/wc-blocks-editor-style.css 15.4 kB
build/wc-blocks-google-analytics.js 1.99 kB
build/wc-blocks-middleware.js 1.48 kB
build/wc-blocks-registry.js 2.74 kB
build/wc-blocks-shared-context.js 1.54 kB
build/wc-blocks-shared-hocs.js 1.75 kB
build/wc-blocks-style-rtl.css 19.7 kB
build/wc-blocks-style.css 19.7 kB
build/wc-blocks-vendors-style-rtl.css 1.05 kB
build/wc-blocks-vendors-style.css 1.05 kB
build/wc-blocks-vendors.js 235 kB
build/wc-blocks.js 3.51 kB
build/wc-payment-method-bacs.js 812 B
build/wc-payment-method-cheque.js 807 B
build/wc-payment-method-cod.js 903 B
build/wc-payment-method-paypal.js 844 B
build/wc-payment-method-stripe.js 12.3 kB
build/wc-settings.js 2.92 kB

compressed-size-action

Copy link
Contributor

@ralucaStan ralucaStan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions github-actions bot added this to the 5.6.0 milestone Jul 27, 2021
@Aljullu Aljullu merged commit d6d4bba into trunk Jul 27, 2021
@Aljullu Aljullu deleted the fix/cart-title-skeleton-class branch July 27, 2021 10:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: cart Issues related to the cart block. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants