This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix handpicked product selections when a store has over 100 products. #4534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -390 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
ralucaStan
approved these changes
Aug 6, 2021
| @@ -39,6 +39,7 @@ const getProductsRequests = ( { | |||
| addQueryArgs( '/wc/store/products', { | |||
| catalog_visibility: 'any', | |||
| include: selected, | |||
| per_page: 0, | |||
There was a problem hiding this comment.
I guess we won't need the comment above anymore:
// If we have a large catalog, we might not get all selected products in the first page
There was a problem hiding this comment.
It's still relevant I think. With smaller catalogs the selections are guaranteed to be returned with the other results. In this use case, our first query might be missing selected things.
|
Thanks for the review 🥳 |
This was referenced Sep 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in
getProductsRequestsfor stores with large catalogs. Our search functionality gets around page limits by including all selected products in a separate request. However, because this request had a limit or 10 products, some selected products would be left out of the list. Setting per_page to 0 (unlimited) resolves this.When trying to make sense of the bug, I refactored the
withSearchedProductsHOC to TypeScript.Fixes #4505
How to test the changes in this Pull Request:
To test this you need a catalog with > 100 products (or you can edit the code to make it require less).
Changelog