Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Twenty Twenty-One: Adjust removable chip background color #4547

Merged
merged 2 commits into from Aug 5, 2021

Conversation

nielslange
Copy link
Member

Fixes #4404

Accessibility

n/a

Screenshots

Before:

#4404-before

After:

#4404-after

How to test the changes in this Pull Request:

  1. Install and activate the WooCommerce plugin
  2. Install and activate this plugin
  3. Create one test product
  4. Create one test coupon
  5. Create one test page
  6. Add the cart block to the created page
  7. Look up the created page
  8. Add a product to the cart
  9. Apply the test coupon
  10. See the incorrect removable chip background color
  11. Apply this PR
  12. See the correct removable chip background color

Changelog

Twenty Twenty-One: Adjust removable chip background color

@nielslange nielslange requested a review from Aljullu August 4, 2021 13:01
@nielslange nielslange requested a review from a team as a code owner August 4, 2021 13:01
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2021

Size Change: +35.5 kB (+3%)

Total Size: 1.1 MB

Filename Size Change
build/active-filters-frontend.js 8.26 kB -10 B (0%)
build/active-filters.js 7.83 kB -13 B (0%)
build/all-products-frontend.js 22.9 kB -78 B (0%)
build/all-products.js 37.2 kB -70 B (0%)
build/all-reviews.js 9.57 kB -32 B (0%)
build/atomic-block-components/add-to-cart--atomic-block-components/button--atomic-block-components/image---a7e2bb9b.js 2.57 kB +1 B (0%)
build/atomic-block-components/add-to-cart--atomic-block-components/button.js 1.82 kB +4 B (0%)
build/atomic-block-components/add-to-cart-frontend.js 8.39 kB -262 B (-3%)
build/atomic-block-components/add-to-cart.js 7.73 kB -4 B (0%)
build/atomic-block-components/category-list-frontend.js 468 B +1 B (0%)
build/atomic-block-components/image-frontend.js 1.88 kB +2 B (0%)
build/atomic-block-components/image.js 1.35 kB -2 B (0%)
build/atomic-block-components/price-frontend.js 2.1 kB +2 B (0%)
build/atomic-block-components/sale-badge-frontend.js 860 B +3 B (0%)
build/atomic-block-components/sku-frontend.js 389 B +1 B (0%)
build/atomic-block-components/stock-indicator-frontend.js 612 B +3 B (0%)
build/atomic-block-components/stock-indicator.js 611 B -1 B (0%)
build/atomic-block-components/summary-frontend.js 904 B -3 B (0%)
build/atomic-block-components/tag-list-frontend.js 466 B +2 B (0%)
build/attribute-filter-frontend.js 18 kB -20 B (0%)
build/attribute-filter.js 11.9 kB +154 B (+1%)
build/blocks-checkout.js 21.2 kB -22 B (0%)
build/cart-frontend.js 77.2 kB -642 B (-1%)
build/cart.js 45.6 kB -29 B (0%)
build/checkout-frontend.js 81.4 kB -608 B (-1%)
build/checkout-i2-frontend.js 51.4 kB -338 B (-1%)
build/checkout-i2.js 48.4 kB -45 B (0%)
build/checkout.js 48.5 kB -25 B (0%)
build/featured-category.js 7.37 kB -23 B (0%)
build/featured-product.js 9.53 kB -22 B (0%)
build/handpicked-products.js 6.53 kB -23 B (0%)
build/price-filter-frontend.js 14.3 kB -13 B (0%)
build/price-filter.js 9.57 kB -12 B (0%)
build/price-format.js 1.37 kB -5 B (0%)
build/product-best-sellers.js 6.69 kB -28 B (0%)
build/product-categories.js 3.37 kB -9 B (0%)
build/product-category.js 7.55 kB -22 B (0%)
build/product-new.js 6.84 kB -30 B (0%)
build/product-on-sale.js 7.19 kB -21 B (0%)
build/product-search.js 2.67 kB -10 B (0%)
build/product-tag.js 6.66 kB -21 B (0%)
build/product-top-rated.js 6.82 kB -24 B (0%)
build/products-by-attribute.js 7.78 kB -25 B (0%)
build/reviews-by-category.js 11.5 kB -34 B (0%)
build/reviews-by-product.js 13.1 kB -56 B (0%)
build/reviews-frontend.js 9 kB -216 B (-2%)
build/single-product-frontend.js 25.8 kB +60 B (0%)
build/single-product.js 9.82 kB -18 B (0%)
build/wc-blocks-data.js 10.8 kB -24 B (0%)
build/wc-blocks-google-analytics.js 1.98 kB -10 B (-1%)
build/wc-blocks-middleware.js 1.47 kB -9 B (-1%)
build/wc-blocks-registry.js 2.74 kB -4 B (0%)
build/wc-blocks-shared-context.js 1.54 kB -1 B (0%)
build/wc-blocks-shared-hocs.js 1.75 kB -2 B (0%)
build/wc-blocks-style-rtl.css 19.9 kB +72 B (0%)
build/wc-blocks-style.css 19.9 kB +72 B (0%)
build/wc-blocks-vendors.js 253 kB +18 kB (+8%) 🔍
build/wc-blocks.js 3.5 kB -6 B (0%)
build/wc-payment-method-bacs.js 806 B -6 B (-1%)
build/wc-payment-method-cheque.js 806 B -1 B (0%)
build/wc-payment-method-cod.js 898 B -5 B (-1%)
build/wc-payment-method-paypal.js 839 B -5 B (-1%)
build/wc-payment-method-stripe.js 12.2 kB -18 B (0%)
build/wc-settings.js 2.91 kB -9 B (0%)
build/vendors--atomic-block-components/add-to-cart-frontend.js 20 kB +20 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size
build/atomic-block-components/add-to-cart--atomic-block-components/image--atomic-block-components/title.js 334 B
build/atomic-block-components/button-frontend.js 1.74 kB
build/atomic-block-components/button.js 875 B
build/atomic-block-components/category-list.js 476 B
build/atomic-block-components/price.js 2.11 kB
build/atomic-block-components/rating-frontend.js 561 B
build/atomic-block-components/rating.js 568 B
build/atomic-block-components/sale-badge.js 867 B
build/atomic-block-components/sku.js 392 B
build/atomic-block-components/summary.js 912 B
build/atomic-block-components/tag-list.js 470 B
build/atomic-block-components/title-frontend.js 1.44 kB
build/atomic-block-components/title.js 1.29 kB
build/checkout-blocks/sample.js 174 B
build/vendors--atomic-block-components/price-frontend.js 5.71 kB
build/wc-blocks-editor-style-rtl.css 15.4 kB
build/wc-blocks-editor-style.css 15.4 kB
build/wc-blocks-vendors-style-rtl.css 1.05 kB
build/wc-blocks-vendors-style.css 1.05 kB

compressed-size-action

Copy link
Contributor

@Aljullu Aljullu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking much better, thanks for fixing this @nielslange! 👏

assets/js/base/components/chip/style.scss Outdated Show resolved Hide resolved
@github-actions github-actions bot added this to the 5.7.0 milestone Aug 5, 2021
@Aljullu Aljullu added focus: global styles Issues that involve styles/css/layout structure. type: bug The issue/PR concerns a confirmed bug. labels Aug 5, 2021
@nielslange nielslange requested a review from Aljullu August 5, 2021 12:22
@nielslange nielslange merged commit 1c13535 into trunk Aug 5, 2021
@nielslange nielslange deleted the fix/4404-Adjust-removable-chip-background-color branch August 5, 2021 12:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: global styles Issues that involve styles/css/layout structure. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Twenty Twenty-One: Adjust removable chip background color
2 participants