Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Reviews by Category: Show review count instead of product count #4552

Merged
merged 1 commit into from Aug 13, 2021

Conversation

nielslange
Copy link
Member

Fixes #4069

Accessibility

n/a

Screenshots

Before:

#4069-before

After:

#4069-after

How to test the changes in this Pull Request:

  1. Install and activate the WooCommerce plugin
  2. Install and activate this plugin
  3. Create one test product
  4. Add one review to the test product
  5. Create one test post
  6. Add the Reviews by Category block
  7. Open the sidebar of the block and open the section Category
  8. See that the count refers to products
  9. Check out this PR
  10. See that the count refers to reviews

Changelog

Reviews by Category: Show review count instead of product count

@nielslange nielslange added type: bug The issue/PR concerns a confirmed bug. focus: components Work that introduces new or updates existing components. block: reviews by category Issues related to the Reviews by Category block. labels Aug 5, 2021
@nielslange nielslange requested a review from a team as a code owner August 5, 2021 15:58
@nielslange nielslange requested review from mikejolley and removed request for a team August 5, 2021 15:58
Copy link
Member

@mikejolley mikejolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely found, approving 🕵🏻

@github-actions github-actions bot added this to the 5.7.0 milestone Aug 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2021

Size Change: +4 B (0%)

Total Size: 1.1 MB

Filename Size Change
build/reviews-by-category.js 11.5 kB +4 B (0%)
ℹ️ View Unchanged
Filename Size
build/active-filters-frontend.js 8.26 kB
build/active-filters.js 7.83 kB
build/all-products-frontend.js 22.9 kB
build/all-products.js 37.2 kB
build/all-reviews.js 9.57 kB
build/atomic-block-components/add-to-cart--atomic-block-components/button--atomic-block-components/image---a7e2bb9b.js 2.57 kB
build/atomic-block-components/add-to-cart--atomic-block-components/button.js 1.82 kB
build/atomic-block-components/add-to-cart--atomic-block-components/image--atomic-block-components/title.js 334 B
build/atomic-block-components/add-to-cart-frontend.js 8.39 kB
build/atomic-block-components/add-to-cart.js 7.73 kB
build/atomic-block-components/button-frontend.js 1.74 kB
build/atomic-block-components/button.js 875 B
build/atomic-block-components/category-list-frontend.js 468 B
build/atomic-block-components/category-list.js 476 B
build/atomic-block-components/image-frontend.js 1.88 kB
build/atomic-block-components/image.js 1.35 kB
build/atomic-block-components/price-frontend.js 2.1 kB
build/atomic-block-components/price.js 2.11 kB
build/atomic-block-components/rating-frontend.js 561 B
build/atomic-block-components/rating.js 568 B
build/atomic-block-components/sale-badge-frontend.js 860 B
build/atomic-block-components/sale-badge.js 867 B
build/atomic-block-components/sku-frontend.js 389 B
build/atomic-block-components/sku.js 392 B
build/atomic-block-components/stock-indicator-frontend.js 612 B
build/atomic-block-components/stock-indicator.js 611 B
build/atomic-block-components/summary-frontend.js 904 B
build/atomic-block-components/summary.js 912 B
build/atomic-block-components/tag-list-frontend.js 466 B
build/atomic-block-components/tag-list.js 470 B
build/atomic-block-components/title-frontend.js 1.44 kB
build/atomic-block-components/title.js 1.29 kB
build/attribute-filter-frontend.js 18 kB
build/attribute-filter.js 11.9 kB
build/blocks-checkout.js 21.2 kB
build/cart-frontend.js 77.2 kB
build/cart.js 45.6 kB
build/checkout-blocks/sample.js 174 B
build/checkout-frontend.js 81.4 kB
build/checkout-i2-frontend.js 51.4 kB
build/checkout-i2.js 48.4 kB
build/checkout.js 48.5 kB
build/featured-category.js 7.37 kB
build/featured-product.js 9.53 kB
build/handpicked-products.js 6.53 kB
build/price-filter-frontend.js 14.3 kB
build/price-filter.js 9.57 kB
build/price-format.js 1.37 kB
build/product-best-sellers.js 6.69 kB
build/product-categories.js 3.37 kB
build/product-category.js 7.55 kB
build/product-new.js 6.84 kB
build/product-on-sale.js 7.19 kB
build/product-search.js 2.67 kB
build/product-tag.js 6.66 kB
build/product-top-rated.js 6.82 kB
build/products-by-attribute.js 7.78 kB
build/reviews-by-product.js 13.1 kB
build/reviews-frontend.js 9 kB
build/single-product-frontend.js 25.8 kB
build/single-product.js 9.82 kB
build/vendors--atomic-block-components/add-to-cart-frontend.js 20 kB
build/vendors--atomic-block-components/price-frontend.js 5.71 kB
build/wc-blocks-data.js 10.8 kB
build/wc-blocks-editor-style-rtl.css 15.4 kB
build/wc-blocks-editor-style.css 15.4 kB
build/wc-blocks-google-analytics.js 1.98 kB
build/wc-blocks-middleware.js 1.47 kB
build/wc-blocks-registry.js 2.74 kB
build/wc-blocks-shared-context.js 1.54 kB
build/wc-blocks-shared-hocs.js 1.75 kB
build/wc-blocks-style-rtl.css 19.9 kB
build/wc-blocks-style.css 19.9 kB
build/wc-blocks-vendors-style-rtl.css 1.05 kB
build/wc-blocks-vendors-style.css 1.05 kB
build/wc-blocks-vendors.js 253 kB
build/wc-blocks.js 3.5 kB
build/wc-payment-method-bacs.js 806 B
build/wc-payment-method-cheque.js 806 B
build/wc-payment-method-cod.js 898 B
build/wc-payment-method-paypal.js 839 B
build/wc-payment-method-stripe.js 12.2 kB
build/wc-settings.js 2.91 kB

compressed-size-action

@senadir senadir merged commit 061d4fe into trunk Aug 13, 2021
@senadir senadir deleted the fix/4069-always-show-review-count branch August 13, 2021 11:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: reviews by category Issues related to the Reviews by Category block. focus: components Work that introduces new or updates existing components. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reviews by Category: sidebar category control shows number of products instead of numbers of reviews
3 participants