Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Add label for Block Title component to satisfy accessibility #4585

Merged

Conversation

tjcafferkey
Copy link
Contributor

@tjcafferkey tjcafferkey commented Aug 16, 2021

Fixes #1680

Accessibility

Screenshots

How to test the changes in this Pull Request:

  1. In a new page add Filter Products By Attribute (and Price) block
  2. Choose an attribute and then click "Done"
  3. Inspect the blocks title within the editor
  4. Observe <label /> element which has for attribute value which corresponds to the <textarea /> id value

Changelog

Add label element to <BlockTitle> component

@tjcafferkey tjcafferkey marked this pull request as ready for review August 16, 2021 15:23
@tjcafferkey tjcafferkey requested a review from a team as a code owner August 16, 2021 15:23
@tjcafferkey tjcafferkey requested review from mikejolley and removed request for a team August 16, 2021 15:23
@opr opr added focus: accessibility The issue/PR is related to accessibility. type: bug The issue/PR concerns a confirmed bug. labels Aug 16, 2021
Copy link
Member

@mikejolley mikejolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this patch. I can confirm this fixes the issue in the editor 👍🏻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: accessibility The issue/PR is related to accessibility. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter blocks (editor): missing label for <textarea> element
3 participants