This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Remove duplicate data attributes #4941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
senadir
and removed request for
a team
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
senadir
reviewed
Oct 14, 2021
| @@ -101,11 +101,15 @@ public function add_data_attributes( $content, $block ) { | |||
| } | |||
|
|
|||
| $attributes = (array) $block['attrs']; | |||
| $exclude_attributes = [ 'className', 'align' ]; | |||
There was a problem hiding this comment.
Works as expected, although a bit limiting as a start. $exclude_attributes can't be extended.
Is it possible for blocks to implement this themselves? as in:
- Ignore the block using a filter.
- Reimplement this function.
There was a problem hiding this comment.
tbh I think under our namespace we want all attributes present. These core attributes are outliers.
Other blocks are not forced to use this handling. render_block filter is available to all.
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
* Remove inject_html_data_attributes * Exclude class/align attributes from injection
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We seem to have duplicate data attributes in the saved HTML markup. This is due to
inject_html_data_attributes()code, as well as the new render filter which applies to all blocks in our namespace:Since
add_data_attributesapplies to allwoocommerceblocks, we can removeinject_html_data_attributes.Fixes #4867
Testing
Changelog