This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
BlockTemplateController: adds the ability to load and manage block template files #4981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
Aljullu
and removed request for
a team
|
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
tjcafferkey
added
focus: FSE
tjcafferkey
commented
Oct 22, 2021
src/BlockTemplatesController.php
Outdated
| $template_files = $this->get_block_templates(); | ||
|
|
||
| foreach ( $template_files as $template_file ) { | ||
| $query_result[] = _gutenberg_build_template_result_from_file( $template_file, 'wp_template' ); |
There was a problem hiding this comment.
What is the significance of the function starting with an underscore (_) here?
There was a problem hiding this comment.
I wonder the same. I would assume that means the function shouldn't be considered public. 🤔 Could we check with somebody from the Gutenberg project about this (via Slack or in their repo)?
There was a problem hiding this comment.
@tjcafferkey pinged me for info here but unfortunately I don't know the answer either.
I would ask in the #core-editor channel in Core slack.
There was a problem hiding this comment.
Just surfacing the reasoning:
The _ prefix means the function it shouldn't be used publicly and can change at any time. Because of this I've duplicated the functions into this repo and will kick off a discussion around this to understand what is needed, and if they can become available for public usage.
Aljullu
reviewed
Oct 22, 2021
There was a problem hiding this comment.
This is working as expected and code looks great. I left some inline comments below, but overall it's looking good.
Regarding the usage of functions prepended by an underscore, I agree we should investigate what that means and whether it's safe to use them in our repo or there are chances they will break in the future.
src/BlockTemplatesController.php
Outdated
| $template_files = $this->get_block_templates(); | ||
|
|
||
| foreach ( $template_files as $template_file ) { | ||
| $query_result[] = _gutenberg_build_template_result_from_file( $template_file, 'wp_template' ); |
There was a problem hiding this comment.
I wonder the same. I would assume that means the function shouldn't be considered public. 🤔 Could we check with somebody from the Gutenberg project about this (via Slack or in their repo)?
Aljullu
approved these changes
Oct 25, 2021
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
frontdevde
changed the title
frontdevde
added
the
type: enhancement
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
* BlockTemplateController * Check if theme already has template * ThemeUtils file to check for FSE enabled themes * Use Gutenberg global gutenberg_supports_block_templates * Remove ThemeUtils reference * Update with code review comments * Delete ThemeUtils and move supports_block_templates check * Duplicate functions from Gutenberg into Utils file * Remove template file * Check template directory and stylesheet directory for template
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
* BlockTemplateController * Check if theme already has template * ThemeUtils file to check for FSE enabled themes * Use Gutenberg global gutenberg_supports_block_templates * Remove ThemeUtils reference * Update with code review comments * Delete ThemeUtils and move supports_block_templates check * Duplicate functions from Gutenberg into Utils file * Remove template file * Check template directory and stylesheet directory for template
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
BlockTemplateControllerwhich will give us the ability to load default block templates in the future. In this specific PR the class is checking if they exist in the theme before loading them from Woo Blockstemplates/block-templates/directory.Fixes #4969
Testing
Automated Tests
Manual Testing
How to test the changes in this Pull Request:
/theme-dir/block-templates/single-product.html/woo-blocks/templates/block-templates/single-product.htmlChangelog