This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add abstract legacy template block #4991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjcafferkey
added
focus: FSE
rubikuserbot
requested review from
a team and
dinhtungdu
and removed request for
a team
|
Size Change: +11.4 kB (+1%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
Aljullu
approved these changes
Oct 28, 2021
There was a problem hiding this comment.
This is testing well and code looks good.
I pushed a couple of commits directly:
- 019caae: to make the placeholder text translatable. I'm not sure if that text was final or it will be replaced by a nicer placeholder in the future, but just in case. 🙂
- d68491e: locked the block so it can't be removed (while still being possible to move it around).
Besides that, I wonder if the block should be renamed to WooCommerce Legacy Template in order to make it clear it's only intended to be used for WooCommerce templates. @tjcafferkey I will leave it up to you to decide.
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
|
Thank you for committing those changes directly @Aljullu I've now learned how to lock blocks, and we can move this PR along quicker 🙌🏻 I've updated the block title to be |
nielslange
changed the title
nielslange
added
the
type: enhancement
frontdevde
added
the
skip-changelog
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
* Legacy Template block * Return render_single_product value * Make placeholder text translatable * Don't allow removing the block * Update block title Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com>
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
* Legacy Template block * Return render_single_product value * Make placeholder text translatable * Don't allow removing the block * Update block title Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4972
Description
This will add a block which given a
templateattribute will enable us to render a specific core PHP template.Whats not included
This PR does not include any visual placeholder UI work, or individual template work which will be done as part of the PR for that specific template (e.g.
single-product.php). This is purely an abstract block which will enable us to render those templates in future PRsTesting
Manual Testing
How to test the changes in this Pull Request:
woo-blocks/templates/block-templates/single-product.htmlChangelog