This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add single product block template #5054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjcafferkey
added
focus: FSE
rubikuserbot
requested review from
a team and
frontdevde
and removed request for
a team
|
Size Change: +9 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
frontdevde
approved these changes
Nov 3, 2021
| @@ -14,7 +14,7 @@ | |||
| } | |||
| } | |||
|
|
|||
| .wp-block-woocommerce-legacy-template__placeholder-image { | |||
| .editor-styles-wrapper .wp-block-woocommerce-legacy-template__placeholder-image { | |||
There was a problem hiding this comment.
If we're adding this class just for increased specificity, can we use wp-block-woocommerce-legacy-template__placeholder instead of .editor-styles-wrapper here? This way we're using only classes we control within the scope of our plugin.
| @@ -0,0 +1 @@ | |||
| <svg width="893" height="451" fill="none" xmlns="http://www.w3.org/2000/svg"><rect width="451" height="451" rx="2" fill="#E5E5E5"/><rect x="470" width="423" height="71" rx="2" fill="#E5E5E5"/><rect x="470" y="147" width="423" height="17" rx="2" fill="#E5E5E5"/><rect x="470" y="172" width="423" height="17" rx="2" fill="#E5E5E5"/><rect x="470" y="305" width="140" height="53" rx="2" fill="#E5E5E5"/><rect x="470" y="217" width="83" height="18" rx="2" fill="#E5E5E5"/><path d="M481.599 96.876a1 1 0 0 1 1.802 0l2.48 5.162a.998.998 0 0 0 .768.558l5.676.764a1 1 0 0 1 .557 1.714l-4.143 3.954a1 1 0 0 0-.293.903l1.028 5.634a1 1 0 0 1-1.459 1.06l-5.04-2.719a1 1 0 0 0-.95 0l-5.04 2.719a1 1 0 0 1-1.459-1.06l1.028-5.634a1 1 0 0 0-.293-.903l-4.143-3.954a1 1 0 0 1 .557-1.714l5.676-.764a.998.998 0 0 0 .768-.558l2.48-5.162ZM506.599 96.876a1 1 0 0 1 1.802 0l2.48 5.162a.998.998 0 0 0 .768.558l5.676.764a1 1 0 0 1 .557 1.714l-4.143 3.954a1 1 0 0 0-.293.903l1.028 5.634a1 1 0 0 1-1.459 1.06l-5.04-2.719a1 1 0 0 0-.95 0l-5.04 2.719a1 1 0 0 1-1.459-1.06l1.028-5.634a1 1 0 0 0-.293-.903l-4.143-3.954a1 1 0 0 1 .557-1.714l5.676-.764a.998.998 0 0 0 .768-.558l2.48-5.162ZM531.599 96.876a1 1 0 0 1 1.802 0l2.48 5.162a.998.998 0 0 0 .768.558l5.676.764a1 1 0 0 1 .557 1.714l-4.143 3.954a1 1 0 0 0-.293.903l1.028 5.634a1 1 0 0 1-1.459 1.06l-5.04-2.719a1 1 0 0 0-.95 0l-5.04 2.719a1 1 0 0 1-1.459-1.06l1.028-5.634a1 1 0 0 0-.293-.903l-4.143-3.954a1 1 0 0 1 .557-1.714l5.676-.764a.998.998 0 0 0 .768-.558l2.48-5.162ZM556.599 96.876a1 1 0 0 1 1.802 0l2.48 5.162a.998.998 0 0 0 .768.558l5.676.764a1 1 0 0 1 .557 1.714l-4.143 3.954a1 1 0 0 0-.293.903l1.028 5.634a1 1 0 0 1-1.459 1.06l-5.04-2.719a1 1 0 0 0-.95 0l-5.04 2.719a1 1 0 0 1-1.459-1.06l1.028-5.634a1 1 0 0 0-.293-.903l-4.143-3.954a1 1 0 0 1 .557-1.714l5.676-.764a.998.998 0 0 0 .768-.558l2.48-5.162ZM581.599 96.876a1 1 0 0 1 1.802 0l2.48 5.162a.998.998 0 0 0 .768.558l5.676.764a1 1 0 0 1 .557 1.714l-4.143 3.954a1 1 0 0 0-.293.903l1.028 5.634a1 1 0 0 1-1.459 1.06l-5.04-2.719a1 1 0 0 0-.95 0l-5.04 2.719a1 1 0 0 1-1.459-1.06l1.028-5.634a1 1 0 0 0-.293-.903l-4.143-3.954a1 1 0 0 1 .557-1.714l5.676-.764a.998.998 0 0 0 .768-.558l2.48-5.162Z" fill="#E5E5E5"/></svg> | |||
There was a problem hiding this comment.
We'll need to replace this with the latest SVG provided by design. OK to leave it as is for now though and update it together with the Archive one in #5053.
nielslange
changed the title
nielslange
added
the
type: enhancement
nielslange
changed the title
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
* Add single-product.html template to render core PHP template * Update placeholder SVG
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
* Add single-product.html template to render core PHP template * Update placeholder SVG
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For WooCommerce merchants to be able to fully utilize block themes, we need the most important WooCommerce core PHP templates to be available as block templates.
This PR adds a block template version of the single-product.php template.
Fixes #5032
Manual Testing
How to test the changes in this Pull Request:
Prerequisite: Please ensure you have a Block Template Theme activated such as TT1 and also the Gutenberg Plugin installed.
Single Product Pagetemplate from theGeneral templatessection.Once you have followed the above steps, add the same template files to your
theme-dir/block-templatesand change the file contents so you can differentiate between the Woo Block template and the Theme template. Repeat the above steps starting from Step 2 and confirm the Theme template is preferred over the Woo Blocks templateChangelog