This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix manual entry within Quantity Inputs #5197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejolley
added
status: needs review
block: cart
rubikuserbot
requested review from
a team and
nielslange
and removed request for
a team
|
Size Change: +8 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
Aljullu
approved these changes
Nov 22, 2021
There was a problem hiding this comment.
Confirming it fixes the issue, thanks for investigating and fixing this, @mikejolley!
WC Blocks 6.3.2 seems to be affected by this. For now, I'm marking this as a blocker of WC Blocks 6.4.0, but I think we might need to include this in a WC Blocks 6.3.3 release as well. cc @nielslange
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
* Use Number.isNaN to cast strings * Avoid changing type function
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
* Use Number.isNaN to cast strings * Avoid changing type function
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typing into quantity inputs is currently not possible because the
isNumbertype check does not convert string-based numbers into actual numbers.This fixes the problem by using
Number.isNaNinstead.Fixes #5187
Testing
Same as below.
User Facing Testing
1Changelog