This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Loading animation: change from pulse to swipe #5362
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
alexflorisca
and removed request for
a team
December 10, 2021 13:10
Size Change: +1.22 kB (0%) Total Size: 818 kB
ℹ️ View Unchanged
|
alexflorisca
approved these changes
Dec 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, both by throttling the network request and the sliding animation is a bit more prominent you're right 👍
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Dec 13, 2021
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
mikejolley
added
the
focus: global styles
Issues that involve styles/css/layout structure.
label
Dec 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled from #5026
I updated the pulsing animation to a 'loading' swipe type animation, based on a Skeleton component I've been using. The pulse was a little too subtle and the swipe seems to better represent that loading is progressing. No issue for this one, just something I thought looked better :)
Screenshots
Changelog