Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Remove Built-in Stripe Integration in favour of Stripe Extension #5449

Merged
merged 4 commits into from Jan 11, 2022

Conversation

mikejolley
Copy link
Member

This PR removes the Stripe integration code (server and client) and Stripe dependencies. This has been included with the Stripe Payment Method Extension since 5.2.0 (2021-05-19).

Closes #5108

Testing

How to test the changes in this Pull Request:

  1. No build errors
  2. Other payment methods still function (do a test checkout)

User Facing Testing

Install the Stripe Payment Method Extension, activate it, enable it and test it works by:

  1. Adding items to your cart
  2. Go to checkout
  3. Select Stripe Credit Card extension and make a payment. Do so while logged in and save the card to your account.
  4. Repeat checkout with a saved card.

Dev Note

The built-in Stripe Payment Method Extension integration has been removed. This has been part of the extension itself since Stripe version 5.2.0 (2021-05-19) and is no longer necessary. If you're using an older version of Stripe (lower than 5.2.0) you'll need to update to have the payment method still shown during Block Checkout.

Changelog

Remove Stripe Payment Method Integration (which is now part of the Stripe Payment Method extension itself)

@mikejolley mikejolley self-assigned this Dec 23, 2021
@rubikuserbot rubikuserbot requested review from a team and ralucaStan and removed request for a team December 23, 2021 14:50
@mikejolley mikejolley added needs: dev note PR that has some text that needs to be included in the release notes. status: needs review category: extensibility Work involving adding or updating extensibility. Useful to combine with other scopes impacted. labels Dec 23, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2021

Size Change: -11.1 kB (-1%)

Total Size: 813 kB

Filename Size Change
build/checkout-blocks/payment-frontend.js 7.38 kB -11 B (0%)
build/checkout-frontend.js 47.5 kB +5 B (0%)
build/checkout.js 47.1 kB -7 B (0%)
build/wc-payment-method-bacs.js 816 B -4 B (0%)
build/wc-payment-method-cheque.js 811 B -5 B (-1%)
build/wc-payment-method-cod.js 909 B -3 B (0%)
build/wc-payment-method-paypal.js 837 B -1 B (0%)
build/wc-payment-method-stripe.js 0 B -11.1 kB (removed) 🏆
ℹ️ View Unchanged
Filename Size
build/active-filters-frontend.js 6.21 kB
build/active-filters.js 7.1 kB
build/all-products-frontend.js 18.6 kB
build/all-products.js 35.2 kB
build/all-reviews.js 8.35 kB
build/atomic-block-components/add-to-cart--atomic-block-components/button--atomic-block-components/image---a7e2bb9b.js 2.76 kB
build/atomic-block-components/add-to-cart--atomic-block-components/button.js 1.48 kB
build/atomic-block-components/add-to-cart-frontend.js 6.87 kB
build/atomic-block-components/add-to-cart.js 6.44 kB
build/atomic-block-components/button-frontend.js 1.48 kB
build/atomic-block-components/button.js 852 B
build/atomic-block-components/category-list-frontend.js 458 B
build/atomic-block-components/category-list.js 458 B
build/atomic-block-components/image-frontend.js 1.37 kB
build/atomic-block-components/image.js 1.05 kB
build/atomic-block-components/price-frontend.js 1.74 kB
build/atomic-block-components/price.js 1.69 kB
build/atomic-block-components/rating-frontend.js 553 B
build/atomic-block-components/rating.js 555 B
build/atomic-block-components/sale-badge-frontend.js 625 B
build/atomic-block-components/sale-badge.js 622 B
build/atomic-block-components/sku-frontend.js 386 B
build/atomic-block-components/sku.js 386 B
build/atomic-block-components/stock-indicator-frontend.js 585 B
build/atomic-block-components/stock-indicator.js 585 B
build/atomic-block-components/summary-frontend.js 874 B
build/atomic-block-components/summary.js 871 B
build/atomic-block-components/tag-list-frontend.js 460 B
build/atomic-block-components/tag-list.js 458 B
build/atomic-block-components/title-frontend.js 1.11 kB
build/atomic-block-components/title.js 1.11 kB
build/attribute-filter-frontend.js 16.3 kB
build/attribute-filter.js 12.6 kB
build/blocks-checkout.js 17.6 kB
build/cart-blocks/accepted-payment-methods-frontend.js 1.15 kB
build/cart-blocks/checkout-button-frontend.js 1.14 kB
build/cart-blocks/empty-cart-frontend.js 345 B
build/cart-blocks/express-payment-frontend.js 4.86 kB
build/cart-blocks/filled-cart-frontend.js 766 B
build/cart-blocks/items-frontend.js 298 B
build/cart-blocks/line-items-frontend.js 5.32 kB
build/cart-blocks/order-summary-frontend.js 8.98 kB
build/cart-blocks/totals-frontend.js 320 B
build/cart-frontend.js 45.4 kB
build/cart.js 44.4 kB
build/checkout-blocks/actions-frontend.js 1.44 kB
build/checkout-blocks/billing-address--checkout-blocks/shipping-address-frontend.js 4.22 kB
build/checkout-blocks/billing-address-frontend.js 884 B
build/checkout-blocks/contact-information-frontend.js 2.94 kB
build/checkout-blocks/express-payment-frontend.js 5.15 kB
build/checkout-blocks/fields-frontend.js 343 B
build/checkout-blocks/order-note-frontend.js 1.13 kB
build/checkout-blocks/order-summary-frontend.js 11.4 kB
build/checkout-blocks/shipping-address-frontend.js 971 B
build/checkout-blocks/shipping-methods-frontend.js 4.82 kB
build/checkout-blocks/terms-frontend.js 1.21 kB
build/checkout-blocks/totals-frontend.js 324 B
build/featured-category.js 8.55 kB
build/featured-product.js 9.91 kB
build/handpicked-products.js 7.33 kB
build/legacy-template.js 2.18 kB
build/mini-cart-component-frontend.js 14.2 kB
build/mini-cart-contents.js 3.6 kB
build/mini-cart-frontend.js 1.76 kB
build/mini-cart.js 6.46 kB
build/price-filter-frontend.js 12.6 kB
build/price-filter.js 8.77 kB
build/price-format.js 1.18 kB
build/product-best-sellers.js 7.54 kB
build/product-categories.js 3.47 kB
build/product-category.js 8.38 kB
build/product-new.js 8.44 kB
build/product-on-sale.js 8.81 kB
build/product-search.js 2.47 kB
build/product-tag.js 8.5 kB
build/product-top-rated.js 8.41 kB
build/products-by-attribute.js 9.22 kB
build/reviews-by-category.js 11.8 kB
build/reviews-by-product.js 12.9 kB
build/reviews-frontend.js 7.24 kB
build/single-product-frontend.js 22.1 kB
build/single-product.js 10.4 kB
build/stock-filter-frontend.js 6.81 kB
build/stock-filter.js 6.83 kB
build/vendors--atomic-block-components/add-to-cart--cart-blocks/order-summary--checkout-blocks/billing-ad--c5eb4dcd-frontend.js 19 kB
build/vendors--atomic-block-components/add-to-cart-frontend.js 6.82 kB
build/vendors--atomic-block-components/price--cart-blocks/line-items--cart-blocks/order-summary--checkout--8a3571de-frontend.js 5.71 kB
build/vendors--cart-blocks/line-items--checkout-blocks/order-summary-frontend.js 3.14 kB
build/vendors--cart-blocks/order-summary--checkout-blocks/billing-address--checkout-blocks/order-summary---eb4d2cec-frontend.js 4.75 kB
build/wc-blocks-data.js 8.84 kB
build/wc-blocks-editor-style-rtl.css 4.55 kB
build/wc-blocks-editor-style.css 4.55 kB
build/wc-blocks-google-analytics.js 1.56 kB
build/wc-blocks-middleware.js 949 B
build/wc-blocks-registry.js 2.7 kB
build/wc-blocks-shared-context.js 1.51 kB
build/wc-blocks-shared-hocs.js 1.14 kB
build/wc-blocks-style-rtl.css 21.7 kB
build/wc-blocks-style.css 21.7 kB
build/wc-blocks-vendors-style-rtl.css 1.28 kB
build/wc-blocks-vendors-style.css 1.28 kB
build/wc-blocks-vendors.js 65.6 kB
build/wc-blocks.js 2.96 kB
build/wc-settings.js 2.61 kB

compressed-size-action

Copy link
Contributor

@opr opr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it's working, code changes look good too. Cheers Mike!

@mikejolley mikejolley merged commit 8c7c900 into trunk Jan 11, 2022
@mikejolley mikejolley deleted the remove/stripe-integration branch January 11, 2022 10:53
@gigitux gigitux added this to the 6.8.0 milestone Jan 17, 2022
@gigitux gigitux added the type: technical debt This issue/PR represents/solves the technical debt of the project. label Jan 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
category: extensibility Work involving adding or updating extensibility. Useful to combine with other scopes impacted. needs: dev note PR that has some text that needs to be included in the release notes. type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove built-in Stripe integration for Cart and Checkout Blocks
3 participants