This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Remove Built-in Stripe Integration in favour of Stripe Extension #5449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
ralucaStan
and removed request for
a team
December 23, 2021 14:50
mikejolley
added
needs: dev note
PR that has some text that needs to be included in the release notes.
status: needs review
category: extensibility
Work involving adding or updating extensibility. Useful to combine with other scopes impacted.
labels
Dec 23, 2021
Size Change: -11.1 kB (-1%) Total Size: 813 kB
ℹ️ View Unchanged
|
opr
approved these changes
Jan 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it's working, code changes look good too. Cheers Mike!
mikejolley
force-pushed
the
remove/stripe-integration
branch
from
January 11, 2022 10:50
c7ba8c7
to
acf4b19
Compare
gigitux
added
the
type: technical debt
This issue/PR represents/solves the technical debt of the project.
label
Jan 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
category: extensibility
Work involving adding or updating extensibility. Useful to combine with other scopes impacted.
needs: dev note
PR that has some text that needs to be included in the release notes.
type: technical debt
This issue/PR represents/solves the technical debt of the project.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the Stripe integration code (server and client) and Stripe dependencies. This has been included with the Stripe Payment Method Extension since 5.2.0 (2021-05-19).
Closes #5108
Testing
How to test the changes in this Pull Request:
User Facing Testing
Install the Stripe Payment Method Extension, activate it, enable it and test it works by:
Dev Note
The built-in Stripe Payment Method Extension integration has been removed. This has been part of the extension itself since Stripe version 5.2.0 (2021-05-19) and is no longer necessary. If you're using an older version of Stripe (lower than 5.2.0) you'll need to update to have the payment method still shown during Block Checkout.
Changelog