Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Product Ratings: Add Global Styles font size and spacing support #5927

Merged

Conversation

danieldudzic
Copy link
Contributor

@danieldudzic danieldudzic commented Feb 23, 2022

This PR adds Global Styles font size and spacing support to the Product Rating block.

Fixes #5669

Screenshots

Before After
Product_Ratings_Block_–_kirigami Product_Ratings_Block_–_kirigami

Manual Testing

How to test the changes in this Pull Request:

  1. Check out this branch and compile the changes
  2. Activate a block theme, like Twenty Twenty Two
  3. Create a new page, and add the All Products block
  4. Edit the Product Ratings block, and make sure the Font size and Spacing block settings are present
  5. Ensure the Font size and Spacing customizations work correctly both on the block level and on the Global Styles level

User Facing Testing

These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).

  • Same as above

Co-authored-by: gigitux gigitux@gmail.com

Automated Tests

  • Changes in this PR are covered by Automated Tests.
    • Unit tests
    • E2E tests

Changelog

Product Ratings: Add Global Styles font size and spacing support

@danieldudzic danieldudzic self-assigned this Feb 23, 2022
@rubikuserbot rubikuserbot requested a review from a team February 23, 2022 17:08
@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2022

Size Change: +93 B (0%)

Total Size: 862 kB

Filename Size Change
build/all-products.js 33.9 kB +40 B (0%)
build/attribute-filter.js 13.1 kB -1 B (0%)
build/cart.js 43.6 kB +6 B (0%)
build/checkout.js 44.7 kB +8 B (0%)
build/mini-cart-contents.js 23.6 kB +1 B (0%)
build/product-button--product-category-list--product-image--product-price--product-rating--product-sale-b--e17c7c01.js 500 B +1 B (0%)
build/product-image.js 1.08 kB -1 B (0%)
build/product-rating-frontend.js 1.15 kB +17 B (+2%)
build/product-rating.js 730 B +17 B (+2%)
build/product-sale-badge.js 680 B -1 B (0%)
build/product-title.js 931 B -1 B (0%)
build/single-product.js 10 kB +5 B (0%)
build/wc-blocks-vendors.js 70.7 kB +2 B (0%)
ℹ️ View Unchanged
Filename Size
build/active-filters-frontend.js 5.92 kB
build/active-filters.js 6.96 kB
build/all-products-frontend.js 18.2 kB
build/all-reviews.js 8.02 kB
build/attribute-filter-frontend.js 16.8 kB
build/blocks-checkout.js 17.4 kB
build/cart-blocks/accepted-payment-methods-frontend.js 1.16 kB
build/cart-blocks/checkout-button-frontend.js 1.15 kB
build/cart-blocks/empty-cart-frontend.js 346 B
build/cart-blocks/express-payment-frontend.js 5.18 kB
build/cart-blocks/filled-cart-frontend.js 759 B
build/cart-blocks/items-frontend.js 300 B
build/cart-blocks/line-items-frontend.js 5.5 kB
build/cart-blocks/order-summary-frontend.js 8.87 kB
build/cart-blocks/totals-frontend.js 320 B
build/cart-frontend.js 45 kB
build/checkout-blocks/actions-frontend.js 1.41 kB
build/checkout-blocks/billing-address--checkout-blocks/shipping-address-frontend.js 4.12 kB
build/checkout-blocks/billing-address-frontend.js 891 B
build/checkout-blocks/contact-information-frontend.js 2.83 kB
build/checkout-blocks/express-payment-frontend.js 5.48 kB
build/checkout-blocks/fields-frontend.js 344 B
build/checkout-blocks/order-note-frontend.js 1.52 kB
build/checkout-blocks/order-summary-frontend.js 11.3 kB
build/checkout-blocks/payment-frontend.js 7.76 kB
build/checkout-blocks/shipping-address-frontend.js 998 B
build/checkout-blocks/shipping-methods-frontend.js 4.74 kB
build/checkout-blocks/terms-frontend.js 1.22 kB
build/checkout-blocks/totals-frontend.js 325 B
build/checkout-frontend.js 47.2 kB
build/featured-category.js 8.62 kB
build/featured-product.js 9.72 kB
build/handpicked-products.js 7.09 kB
build/legacy-template.js 2.19 kB
build/mini-cart-component-frontend.js 16.5 kB
build/mini-cart-contents-block/empty-cart-frontend.js 329 B
build/mini-cart-contents-block/filled-cart-frontend.js 230 B
build/mini-cart-contents-block/footer--mini-cart-contents-block/products-table-frontend.js 5.32 kB
build/mini-cart-contents-block/footer-frontend.js 5.67 kB
build/mini-cart-contents-block/items-frontend.js 226 B
build/mini-cart-contents-block/products-table-frontend.js 5.36 kB
build/mini-cart-contents-block/shopping-button-frontend.js 287 B
build/mini-cart-contents-block/title-frontend.js 367 B
build/mini-cart-frontend.js 1.72 kB
build/mini-cart.js 6.33 kB
build/price-filter-frontend.js 12.1 kB
build/price-filter.js 8.49 kB
build/price-format.js 1.19 kB
build/product-add-to-cart--product-button--product-category-list--product-image--product-price--product-r--a0326d00.js 222 B
build/product-add-to-cart--product-button--product-image--product-title.js 2.64 kB
build/product-add-to-cart-frontend.js 7 kB
build/product-add-to-cart.js 7.47 kB
build/product-best-sellers.js 7.37 kB
build/product-button-frontend.js 2.08 kB
build/product-button.js 2.29 kB
build/product-categories.js 3.17 kB
build/product-category-list-frontend.js 923 B
build/product-category-list.js 499 B
build/product-category.js 8.48 kB
build/product-image-frontend.js 1.85 kB
build/product-new.js 7.67 kB
build/product-on-sale.js 7.98 kB
build/product-price-frontend.js 1.93 kB
build/product-price.js 1.51 kB
build/product-sale-badge-frontend.js 1.09 kB
build/product-search.js 2.18 kB
build/product-sku-frontend.js 380 B
build/product-sku.js 382 B
build/product-stock-indicator-frontend.js 1.03 kB
build/product-stock-indicator.js 620 B
build/product-summary-frontend.js 1.33 kB
build/product-summary.js 918 B
build/product-tag-list-frontend.js 917 B
build/product-tag-list.js 495 B
build/product-tag.js 7.81 kB
build/product-title-frontend.js 1.31 kB
build/product-top-rated.js 7.9 kB
build/products-by-attribute.js 8.39 kB
build/reviews-by-category.js 11.4 kB
build/reviews-by-product.js 12.6 kB
build/reviews-frontend.js 6.97 kB
build/single-product-frontend.js 21.6 kB
build/stock-filter-frontend.js 6.5 kB
build/stock-filter.js 6.57 kB
build/vendors--cart-blocks/line-items--cart-blocks/order-summary--checkout-blocks/order-summary--checkout--6efbf40e-frontend.js 5.26 kB
build/vendors--cart-blocks/line-items--checkout-blocks/order-summary--mini-cart-contents-block/products-table-frontend.js 3.14 kB
build/vendors--cart-blocks/order-summary--checkout-blocks/billing-address--checkout-blocks/order-summary---4f3822fa-frontend.js 19.3 kB
build/vendors--cart-blocks/order-summary--checkout-blocks/billing-address--checkout-blocks/order-summary---eb4d2cec-frontend.js 4.74 kB
build/vendors--mini-cart-contents-block/footer--mini-cart-contents-block/products-table-frontend.js 7.35 kB
build/vendors--product-add-to-cart-frontend.js 7.54 kB
build/wc-blocks-data.js 9.83 kB
build/wc-blocks-editor-style-rtl.css 4.84 kB
build/wc-blocks-editor-style.css 4.84 kB
build/wc-blocks-google-analytics.js 1.56 kB
build/wc-blocks-middleware.js 953 B
build/wc-blocks-registry.js 2.7 kB
build/wc-blocks-shared-context.js 1.52 kB
build/wc-blocks-shared-hocs.js 1.14 kB
build/wc-blocks-style-rtl.css 22.2 kB
build/wc-blocks-style.css 22.2 kB
build/wc-blocks-vendors-style-rtl.css 1.28 kB
build/wc-blocks-vendors-style.css 1.28 kB
build/wc-blocks.js 2.62 kB
build/wc-payment-method-bacs.js 816 B
build/wc-payment-method-cheque.js 811 B
build/wc-payment-method-cod.js 909 B
build/wc-payment-method-paypal.js 837 B
build/wc-settings.js 2.61 kB

compressed-size-action

Copy link
Contributor

@tomasztunik tomasztunik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small tweaks but looks good 💪

assets/js/atomic/blocks/product-elements/rating/support.js Outdated Show resolved Hide resolved
src/BlockTypes/ProductRating.php Outdated Show resolved Hide resolved
@github-actions github-actions bot added this to the 7.3.0 milestone Mar 10, 2022
@danieldudzic danieldudzic merged commit 46e73de into trunk Mar 11, 2022
@danieldudzic danieldudzic deleted the add/5669-font-size-and-spacing-support-for-ratings branch March 11, 2022 15:52
@tjcafferkey tjcafferkey added the type: enhancement The issue is a request for an enhancement. label Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product Rating - Add support for spacing with Global Styles API
4 participants