Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Release: 7.2.0 #6003

Closed
wants to merge 62 commits into from
Closed

Release: 7.2.0 #6003

wants to merge 62 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 7, 2022

This is the release pull request for WooCommerce Blocks plugin 7.2.0.

Dev Notes

As part of finalising the Store API, we've removed all X- prefixes from headers since this is no longer a recommended practice. The X-WC-Store-API-Nonce has been renamed to just Nonce going forward. If you've been consuming the experimental Store API, this will need to be renamed in your client. This also includes X-WC-Store-Api-Nonce-Timestamp to Nonce-Timestamp and X-WC-Store-User to User-ID. See #6020

Changelog


#### Bug Fixes

- StoreAPI: Clear all wc notice types in the cart validation context [#5983](https://github.com/woocommerce/woocommerce-gutenberg-products-block/pull/5983)
- Fix loading more WC core translations in locales where WC Blocks is not localized for some strings.
- Ensure shipping address is set for virtual orders to prevent missing country errors. [#6050](https://github.com/woocommerce/woocommerce-gutenberg-products-block/pull/6050)

#### Enhancements

- Memoize/cache filter results so that we don't call third party filters too often [#5143](https://github.com/woocommerce/woocommerce-gutenberg-products-block/pull/5143)
- Add font-style and font-weight support for the Product Categories List block. ([5928](https://github.com/woocommerce/woocommerce-gutenberg-products-block/pull/5928))

#### Various

- Remove v1 string from Store Keys. ([5987](https://github.com/woocommerce/woocommerce-gutenberg-products-block/pull/5987))
- Introduce the `InvalidCartException` for handling cart validation. ([5904](https://github.com/woocommerce/woocommerce-gutenberg-products-block/pull/5904))
- Renamed Store API custom headers to remove `X-WC-Store-API` prefixes. [#5983](https://github.com/woocommerce/woocommerce-gutenberg-products-block/pull/5983)
- Normalised Store API error codes [#5992](https://github.com/woocommerce/woocommerce-gutenberg-products-block/pull/5992)
- Deprecated `woocommerce_blocks_checkout_order_processed` in favour of `woocommerce_store_api_checkout_order_processed`
- Deprecated `woocommerce_blocks_checkout_update_order_meta` in favour of `woocommerce_store_api_checkout_update_order_meta`
- Deprecated `woocommerce_blocks_checkout_update_order_from_request` in favour of `woocommerce_store_api_checkout_update_order_from_request`

Communication

Prepared Updates

Please leave a comment on this PR with links to the following:

  • Release announcement (announcement post on developer.woocommerce.com published after release): https://developer.woocommerce.com/?p=12114&preview=true
  • Happiness engineering or Happiness/Support (if special instructions needed).
  • Relevant developer documentation (if applicable).

Quality

  • Testing Instructions are included in this PR
  • Any performance impacts are documented.

🚀 This pull request was generated by the automations bot triggered by the creation of the branch: release/7.2.0. cc @mikejolley

@github-actions
Copy link
Contributor Author

github-actions bot commented Mar 7, 2022

The release pull request has been created! This checklist is a guide to follow for the remainder of the release process. You can check off each item in this list once completed.

  • Checkout the release branch locally.

Initial Preparation

  • Add the changelog to readme.txt
    • Add the version and date to the changelog section within readme.txt, e.g. = 7.2.0 - YYYY-MM-DD =
    • Copy the changelog from the pull request description above into this new section
  • Update compatibility sections (if applicable). Note: Do not change the stable tag or plugin version; this is automated.
    • Update Requires at least, Tested up to, and Requires PHP sections at the top of readme.txt. Note, this should also be the latest WordPress version available at time of release.
    • Update Requires at least, Requires PHP, WC requires at least, and WC tested up to at the top of woocommerce-gutenberg-products-block.php. Note, this should include requiring the latest WP version at the time of release. For WC requires at least, use L1 (we publicly communicate L0 but technically support L1 to provide some space for folks to update). So this means if the current version of WooCommerce core is 5.8.0, then you'll want to put 5.7.0 here.
    • If necessary, update the value of $minimum_wp_version at the top of the woocommerce-gutenberg-products-block.php file to the latest available version of WordPress.
    • If necessary, update the phpcs.xml file to reference the minimum WP version supported by WooCommerce Core. It would be this line: <config name="minimum_supported_wp_version" value="5.6" />.
  • Push above changes to the release branch.

Write Testing Notes

When creating testing notes, please write them from the perspective of a "user" (merchant) familiar with WooCommerce. So you don't have to spell out exact steps for common setup scenarios (eg. "Create a product"), but do be specific about the thing being tested. Include screenshots demonstrating expectations where that will be helpful.

Additionally, make sure to differentiate between things in the testing notes that only apply to the feature plugin and things that apply when included in WooCommerce core as there may be variations there.

  • Run npm ci
  • Run npm run package-plugin:deploy. This will create a zip of the current branch build locally.
    • Note: The zip file is functionally equivalent to what gets released except the version bump.
  • Create testing notes for the release. You can usually go through the pull requests linked in the changelog and grab testing notes from each pull.
    • Add the notes to docs/testing/releases
    • Update the docs/testing/releases/README.md file index.
  • Copy a link to the release zip you created earlier into the testing notes. To generate the link you can upload the zip as an attachment in a GitHub comment and then just copy the path (without publishing the comment).
  • Commit and push the testing docs to the release branch.
  • Smoke test built release zip using the testing instructions you created:
    • At least one other person should test the built zip - ping the current Rubik porter to be this person.
    • Test in a clean environment, e.g. Jurassic.Ninja site.
    • Test existing WooCommerce Blocks content works correctly after update (no block validation errors).
    • Test to confirm blocks are available and work correctly in oldest supported WordPress version (e.g. 5.3).
    • Confidence check - check blocks are available and function.
    • Test to confirm new features/fixes are working correctly.
    • Test any UI changes in mobile and desktop views.
    • Smoke test – test a cross section of core functionality.

Update Pull Request description and get approvals

  • Go through the description of the release pull request and edit it to update all the sections and checklist instructions there.
  • Ask a team member to review the changes in the release pull request and for anyone who has done testing that they approve the pull request.

Ensure hub is set up and you're authenticated

  • Make sure you've got hub installed (brew install hub)
  • Make sure hub api user returns JSON with information about your GitHub user account, if it doesn't:
    • Create a GitHub access token with the repo permission.
    • Set the environment variables: GITHUB_USERNAME with your GitHub Username, and GITHUB_TOKEN with the token you just generated. (You may want to add these to .bashrc or the equivalent)
    • Run hub api user again and ensure JSON with information about your GitHub user account is returned.

Push the button - Deploy!

  • Execute npm run deploy
    • The script will ask you to enter the version number to tag. Please enter the version we're releasing right now. Do not publish any dev tags as a release.
    • Note: the script automatically updates version numbers on Github (commits on your behalf).
    • ALERT: This script will ask you if this release will be deployed to WordPress.org. You should answer yes for this release even if it is a pre-release.
    • A GitHub release will automatically be created and this will trigger a workflow that automatically deploys the plugin to WordPress.org.

If this release is deployed to WordPress.org...

  • An email confirmation is required before the new version will be released, so check your email in order to confirm the release.
  • Edit the GitHub release and copy changelog into the release notes. Ensure there is a release with the correct version, the one you entered above.
  • The #team-rubik slack instance will be notified about the progress with the WordPress.org deploy. Watch for that. If anything goes wrong, an error will be reported and you can followup via the GitHub actions tab and the log for that workflow.
  • After the wp.org workflow completes, confirm the following

After Workflow completes

  • [ ] Merge this pull request back into trunk. This may have merge conflicts needing resolved if there are any cherry-picked commits in the release branch.
  • Update version on the trunk branch to be for the next version of the plugin and include the dev suffix (e.g. something like 2.6-dev) for the next version. Be sure to update the version number in the following files:
    • package-lock.json
    • package.json
    • readme.txt
    • src/Package.php
    • woocommerce-gutenberg-products-block.php.
  • Update the schedules p2 with the shipped date for the release (Pca54o-1N-p2).
  • Clean up the release milestone and Zenhub.
    • Edit the GitHub milestone and add the current date as the due date (this is used to track ship date as well).
    • Close the milestone.
    • Remove any unfinished issues from the Zenhub epics completed by this release and then close the epics.

Publish posts

  • Post release announcement on WooCommerce Developer Blog. Use previous posts for inspiration. If the release contains new features, or API changes, explain what's new so Woo devs/builders/merchants can get excited about it. This post can take time to get right - get feedback from the team, and don't rush it :)
    • Ensure the release notes are included in the post verbatim.
    • Don't forget to use category WooCommerce Blocks Release Notes for the post.
  • Announce the release internally (#woo-announcements slack).
  • Update user-facing documentation as needed. When the plugin is released, ensure user-facing documentation is kept up to date with new blocks and compatibility information. The dev team should update documents in collaboration with support team and WooCommerce docs guild. In particular, please review and update as needed:
    • Are there any new blocks in this release? Ensure they have adequate user documentation.
    • Ensure any major improvements or changes are documented.
    • Update minimum supported versions (WordPress, WooCommerce Core) and other requirements where necessary, including:

Pull request in WooCommerce Core for Package update

This only needs to be done if this release is the last release of the feature plugin before code freeze in the WooCommerce core cycle. If this condition doesn't exist you can skip this section.

  • Remind whoever is porter this week to audit our codebase to ensure this experimental interface document is up to date. See Pca54o-rM-p2 for more details.
  • Create a pull request for updating the package in the WooCommerce Core Repository that bumps the package version for the Woo Blocks package to the version being pulled in.
    • The content for the pull release can follow this example. Update the plugins/woocommerce/composer.json file and then run composer update. In the PR description you will link to all the important things that have already been prepared since the version you replaced. Note, you need to make sure you link to all the related documents for the plugin releases since the last package version bump in Woo Core.
      • Please add a changelog to the content which is aggregated from all the releases included in the package bump. The changelog should only list things surfaced to users of the package in WooCommerce core (i.e. excluding things only available in the feature plugin or development builds). This changelog will be used in the release notes for the WooCommerce release.
    • Run through the testing checklist to ensure everything works in that branch for that package bump. Note: Testing should include ensuring any features/new blocks that are supposed to be behind feature gating for the core merge of this package update are working as expected.
    • Testing should include completing the Smoke testing checklist. It's up to you to verify that those tests have been done.
    • Verify and make any additional edits to the pull request description for things like: Changelog to be included with WooCommerce core, additional communication that might be needed elsewhere, additional marketing communication notes that may be needed etc.
    • After the checklist is complete and the testing is done, it will be up to the WooCommerce core team to approve and merge the pull request.
  • Make sure you join the #woo-core-releases Slack channel to represent Woo Blocks for the release of WooCommerce core this version is included in.
🚀 This comment was generated by the automations bot triggered by the creation of the branch: release/7.2.0. cc @mikejolley

@mikejolley mikejolley self-assigned this Mar 7, 2022
@github-actions
Copy link
Contributor Author

github-actions bot commented Mar 7, 2022

Size Change: -853 B (0%)

Total Size: 862 kB

Filename Size Change
build/active-filters-frontend.js 5.92 kB -356 B (-6%)
build/active-filters.js 6.96 kB +16 B (0%)
build/all-products-frontend.js 18.2 kB -363 B (-2%)
build/all-products.js 33.9 kB -37 B (0%)
build/all-reviews.js 8.02 kB -11 B (0%)
build/atomic-block-components/add-to-cart--atomic-block-components/button--atomic-block-components/catego--90468e1a.js 0 B -223 B (removed) 🏆
build/atomic-block-components/add-to-cart--atomic-block-components/button--atomic-block-components/image---a7e2bb9b.js 0 B -2.64 kB (removed) 🏆
build/atomic-block-components/add-to-cart-frontend.js 0 B -7.01 kB (removed) 🏆
build/atomic-block-components/add-to-cart.js 0 B -7.49 kB (removed) 🏆
build/atomic-block-components/button--atomic-block-components/category-list--atomic-block-components/imag--f11cdc7a.js 0 B -500 B (removed) 🏆
build/atomic-block-components/button-frontend.js 0 B -2.08 kB (removed) 🏆
build/atomic-block-components/button.js 0 B -2.3 kB (removed) 🏆
build/atomic-block-components/category-list-frontend.js 0 B -922 B (removed) 🏆
build/atomic-block-components/category-list.js 0 B -500 B (removed) 🏆
build/atomic-block-components/image-frontend.js 0 B -1.86 kB (removed) 🏆
build/atomic-block-components/image.js 0 B -1.08 kB (removed) 🏆
build/atomic-block-components/price-frontend.js 0 B -1.95 kB (removed) 🏆
build/atomic-block-components/price.js 0 B -1.51 kB (removed) 🏆
build/atomic-block-components/rating-frontend.js 0 B -1.14 kB (removed) 🏆
build/atomic-block-components/rating.js 0 B -717 B (removed) 🏆
build/atomic-block-components/sale-badge-frontend.js 0 B -1.1 kB (removed) 🏆
build/atomic-block-components/sale-badge.js 0 B -685 B (removed) 🏆
build/atomic-block-components/sku-frontend.js 0 B -385 B (removed) 🏆
build/atomic-block-components/sku.js 0 B -386 B (removed) 🏆
build/atomic-block-components/stock-indicator-frontend.js 0 B -1.04 kB (removed) 🏆
build/atomic-block-components/stock-indicator.js 0 B -624 B (removed) 🏆
build/atomic-block-components/summary-frontend.js 0 B -1.34 kB (removed) 🏆
build/atomic-block-components/summary.js 0 B -923 B (removed) 🏆
build/atomic-block-components/tag-list-frontend.js 0 B -924 B (removed) 🏆
build/atomic-block-components/tag-list.js 0 B -498 B (removed) 🏆
build/atomic-block-components/title-frontend.js 0 B -1.31 kB (removed) 🏆
build/atomic-block-components/title.js 0 B -933 B (removed) 🏆
build/attribute-filter-frontend.js 16.8 kB +46 B (0%)
build/attribute-filter.js 13.1 kB +12 B (0%)
build/blocks-checkout.js 17.4 kB -15 B (0%)
build/cart-blocks/accepted-payment-methods-frontend.js 1.16 kB +21 B (+2%)
build/cart-blocks/checkout-button-frontend.js 1.15 kB -3 B (0%)
build/cart-blocks/express-payment-frontend.js 5.18 kB -14 B (0%)
build/cart-blocks/filled-cart-frontend.js 759 B -8 B (-1%)
build/cart-blocks/items-frontend.js 300 B +1 B (0%)
build/cart-blocks/line-items-frontend.js 5.5 kB -2 B (0%)
build/cart-blocks/order-summary-frontend.js 8.87 kB -11 B (0%)
build/cart-frontend.js 45 kB -374 B (-1%)
build/cart.js 43.6 kB -10 B (0%)
build/checkout-blocks/actions-frontend.js 1.41 kB -3 B (0%)
build/checkout-blocks/billing-address--checkout-blocks/shipping-address-frontend.js 4.12 kB -12 B (0%)
build/checkout-blocks/contact-information-frontend.js 2.83 kB -9 B (0%)
build/checkout-blocks/express-payment-frontend.js 5.48 kB -14 B (0%)
build/checkout-blocks/order-note-frontend.js 1.52 kB +384 B (+34%) 🚨
build/checkout-blocks/order-summary-frontend.js 11.3 kB -1 B (0%)
build/checkout-blocks/payment-frontend.js 7.76 kB -21 B (0%)
build/checkout-blocks/shipping-address-frontend.js 998 B +1 B (0%)
build/checkout-blocks/shipping-methods-frontend.js 4.74 kB +5 B (0%)
build/checkout-blocks/terms-frontend.js 1.22 kB -2 B (0%)
build/checkout-blocks/totals-frontend.js 325 B +2 B (+1%)
build/checkout-frontend.js 47.2 kB -383 B (-1%)
build/checkout.js 44.7 kB -34 B (0%)
build/featured-category.js 8.62 kB -14 B (0%)
build/featured-product.js 9.72 kB -16 B (0%)
build/handpicked-products.js 7.09 kB -16 B (0%)
build/legacy-template.js 2.19 kB +1 B (0%)
build/mini-cart-component-frontend.js 16.5 kB +452 B (+3%)
build/mini-cart-contents-block/empty-cart-frontend.js 329 B -34 B (-9%)
build/mini-cart-contents-block/filled-cart-frontend.js 230 B +8 B (+4%)
build/mini-cart-contents-block/footer--mini-cart-contents-block/products-table-frontend.js 5.32 kB -8 B (0%)
build/mini-cart-contents-block/footer-frontend.js 5.67 kB +33 B (+1%)
build/mini-cart-contents-block/items-frontend.js 226 B +20 B (+10%) ⚠️
build/mini-cart-contents-block/products-table-frontend.js 5.36 kB +23 B (0%)
build/mini-cart-contents-block/shopping-button-frontend.js 287 B +27 B (+10%) ⚠️
build/mini-cart-contents-block/title-frontend.js 367 B +19 B (+5%) 🔍
build/mini-cart-contents.js 23.6 kB +25 B (0%)
build/mini-cart.js 6.33 kB -63 B (-1%)
build/price-filter-frontend.js 12.1 kB -361 B (-3%)
build/price-filter.js 8.49 kB +18 B (0%)
build/product-best-sellers.js 7.37 kB -17 B (0%)
build/product-categories.js 3.17 kB -4 B (0%)
build/product-category.js 8.48 kB -29 B (0%)
build/product-new.js 7.67 kB -18 B (0%)
build/product-on-sale.js 7.98 kB -19 B (0%)
build/product-search.js 2.18 kB -5 B (0%)
build/product-tag.js 7.81 kB -15 B (0%)
build/product-top-rated.js 7.9 kB -15 B (0%)
build/products-by-attribute.js 8.39 kB -17 B (0%)
build/reviews-by-category.js 11.4 kB -22 B (0%)
build/reviews-by-product.js 12.6 kB -21 B (0%)
build/reviews-frontend.js 6.97 kB -374 B (-5%)
build/single-product-frontend.js 21.6 kB -364 B (-2%)
build/single-product.js 10 kB -19 B (0%)
build/stock-filter-frontend.js 6.5 kB +6 B (0%)
build/stock-filter.js 6.57 kB +10 B (0%)
build/vendors--atomic-block-components/add-to-cart--cart-blocks/order-summary--checkout-blocks/billing-ad--c5eb4dcd-frontend.js 0 B -19 kB (removed) 🏆
build/vendors--atomic-block-components/add-to-cart-frontend.js 0 B -7.51 kB (removed) 🏆
build/vendors--atomic-block-components/price--cart-blocks/line-items--cart-blocks/order-summary--checkout--194c50bf-frontend.js 0 B -5.26 kB (removed) 🏆
build/vendors--cart-blocks/order-summary--checkout-blocks/billing-address--checkout-blocks/order-summary---eb4d2cec-frontend.js 4.74 kB -1 B (0%)
build/vendors--mini-cart-contents-block/footer--mini-cart-contents-block/products-table-frontend.js 7.35 kB -364 B (-5%)
build/wc-blocks-data.js 9.83 kB +4 B (0%)
build/wc-blocks-registry.js 2.7 kB +2 B (0%)
build/wc-blocks-shared-context.js 1.52 kB +5 B (0%)
build/wc-blocks-shared-hocs.js 1.14 kB -3 B (0%)
build/wc-blocks-style-rtl.css 22.2 kB -16 B (0%)
build/wc-blocks-style.css 22.2 kB -15 B (0%)
build/wc-blocks-vendors.js 70.7 kB +1.32 kB (+2%)
build/product-add-to-cart--product-button--product-category-list--product-image--product-price--product-r--a0326d00.js 222 B +222 B (new file) 🆕
build/product-add-to-cart--product-button--product-image--product-title.js 2.64 kB +2.64 kB (new file) 🆕
build/product-add-to-cart-frontend.js 7 kB +7 kB (new file) 🆕
build/product-add-to-cart.js 7.47 kB +7.47 kB (new file) 🆕
build/product-button--product-category-list--product-image--product-price--product-rating--product-sale-b--e17c7c01.js 499 B +499 B (new file) 🆕
build/product-button-frontend.js 2.08 kB +2.08 kB (new file) 🆕
build/product-button.js 2.29 kB +2.29 kB (new file) 🆕
build/product-category-list-frontend.js 923 B +923 B (new file) 🆕
build/product-category-list.js 499 B +499 B (new file) 🆕
build/product-image-frontend.js 1.85 kB +1.85 kB (new file) 🆕
build/product-image.js 1.08 kB +1.08 kB (new file) 🆕
build/product-price-frontend.js 1.93 kB +1.93 kB (new file) 🆕
build/product-price.js 1.51 kB +1.51 kB (new file) 🆕
build/product-rating-frontend.js 1.13 kB +1.13 kB (new file) 🆕
build/product-rating.js 713 B +713 B (new file) 🆕
build/product-sale-badge-frontend.js 1.09 kB +1.09 kB (new file) 🆕
build/product-sale-badge.js 681 B +681 B (new file) 🆕
build/product-sku-frontend.js 380 B +380 B (new file) 🆕
build/product-sku.js 382 B +382 B (new file) 🆕
build/product-stock-indicator-frontend.js 1.03 kB +1.03 kB (new file) 🆕
build/product-stock-indicator.js 620 B +620 B (new file) 🆕
build/product-summary-frontend.js 1.33 kB +1.33 kB (new file) 🆕
build/product-summary.js 918 B +918 B (new file) 🆕
build/product-tag-list-frontend.js 917 B +917 B (new file) 🆕
build/product-tag-list.js 495 B +495 B (new file) 🆕
build/product-title-frontend.js 1.31 kB +1.31 kB (new file) 🆕
build/product-title.js 932 B +932 B (new file) 🆕
build/vendors--cart-blocks/line-items--cart-blocks/order-summary--checkout-blocks/order-summary--checkout--6efbf40e-frontend.js 5.26 kB +5.26 kB (new file) 🆕
build/vendors--cart-blocks/order-summary--checkout-blocks/billing-address--checkout-blocks/order-summary---4f3822fa-frontend.js 19.3 kB +19.3 kB (new file) 🆕
build/vendors--product-add-to-cart-frontend.js 7.54 kB +7.54 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size
build/cart-blocks/empty-cart-frontend.js 346 B
build/cart-blocks/totals-frontend.js 320 B
build/checkout-blocks/billing-address-frontend.js 891 B
build/checkout-blocks/fields-frontend.js 344 B
build/mini-cart-frontend.js 1.72 kB
build/price-format.js 1.19 kB
build/vendors--cart-blocks/line-items--checkout-blocks/order-summary--mini-cart-contents-block/products-table-frontend.js 3.14 kB
build/wc-blocks-editor-style-rtl.css 4.84 kB
build/wc-blocks-editor-style.css 4.84 kB
build/wc-blocks-google-analytics.js 1.56 kB
build/wc-blocks-middleware.js 953 B
build/wc-blocks-vendors-style-rtl.css 1.28 kB
build/wc-blocks-vendors-style.css 1.28 kB
build/wc-blocks.js 2.62 kB
build/wc-payment-method-bacs.js 816 B
build/wc-payment-method-cheque.js 811 B
build/wc-payment-method-cod.js 909 B
build/wc-payment-method-paypal.js 837 B
build/wc-settings.js 2.61 kB

compressed-size-action

mikejolley and others added 19 commits March 9, 2022 10:21
…6007

Add feature gate for the global styles for Product Sale Badge block
we want to always load lazy loaded components from their default paths
to avoid having to handle importing components in different ways for
regular and atomic component packages
The Site Editor is expecting the footer parts to be there or it will try to
load them anyways and throw a 404. It's not breaking, but it's polluting
the console.
Previously, we used a util called `trashAllPosts` which navigated to the post UI
and deleted all the posts to tear down any side-effects of template editing tests.

However, with a [recent change](WordPress/wordpress-develop@14e20f7),
WP Core removed the UI for those and that made our tests meet a 500 error.

Using the REST API should also make everything faster.
was still present in attribute-filter.test.js
Before it was responsible for enabling translations for all the atomic blocks
Copy link
Member

@senadir senadir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I didn't test (I trust that @tarhi-saad did), the code looks good even thou it's really big.

@mikejolley
Copy link
Member

Core PR is up woocommerce/woocommerce#32075

I've picked changes from this into trunk.

@mikejolley mikejolley closed this Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants