This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Create deprecated_dependency wrapper to log errors conditionally #6074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
tarhi-saad
and removed request for
a team
mikejolley
added
status: needs review
focus: rest api
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
|
Size Change: 0 B Total Size: 862 kB ℹ️ View Unchanged
|
tarhi-saad
approved these changes
Mar 22, 2022
senadir
approved these changes
Mar 22, 2022
senadir
pushed a commit
that referenced
this pull request
Mar 23, 2022
Store Editing E2E tests are failing because of an upstream regression, not related to this PR
senadir
added a commit
that referenced
this pull request
Mar 23, 2022
* Empty commit for release pull request * Create deprecated_dependency wrapper to log errors conditionally (#6074) Store Editing E2E tests are failing because of an upstream regression, not related to this PR * add readme * add testing steps * Bumping version strings to new version. * Bumping version strings to new version. * Bumping version strings to new version. Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Mike Jolley <mike.jolley@me.com> Co-authored-by: Nadir Seghir <nadir.seghir@gmail.com>
senadir
added a commit
to woocommerce/woocommerce
that referenced
this pull request
Mar 23, 2022
This pull updates the WooCommerce Blocks plugin to 7.2.1. It is intended to target WooCommerce 6.4 for release. This supercedes #32075. Details from all the different releases included in this pull: ## Blocks 7.2.1 [Release PR](woocommerce/woocommerce-blocks#6072) [Testing Instruction](https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/trunk/docs/testing/releases/721.md) ### Changelog entry #### The following changelog entries are only those that impact existing blocks and functionality surfaced to users: #### Bug fixes - Don't trigger class deprecations notices if headers are already sent [#6074](woocommerce/woocommerce-blocks#6074) ### Changelog entry > Dev - Update WooCommerce Blocks version to 7.2.1
3 tasks
tjcafferkey
changed the title
tjcafferkey
changed the title
tjcafferkey
added
type: enhancement
chihsuan
pushed a commit
to woocommerce/woocommerce
that referenced
this pull request
Mar 29, 2022
This pull updates the WooCommerce Blocks plugin to 7.2.1. It is intended to target WooCommerce 6.4 for release. This supercedes #32075. Details from all the different releases included in this pull: ## Blocks 7.2.1 [Release PR](woocommerce/woocommerce-blocks#6072) [Testing Instruction](https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/trunk/docs/testing/releases/721.md) ### Changelog entry #### The following changelog entries are only those that impact existing blocks and functionality surfaced to users: #### Bug fixes - Don't trigger class deprecations notices if headers are already sent [#6074](woocommerce/woocommerce-blocks#6074) ### Changelog entry > Dev - Update WooCommerce Blocks version to 7.2.1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a wrapper for class/namespace deprecation that:
For the namespace and class changes in the API, this will surface errors in the logs only until Blocks 7.4 in which case they will surface inline if WP_DEBUG mode is on.
Fixes #6070
Testing
7.4from the function calls. Repeat steps 2-4 and confirm logs are used.Changelog