Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API - woocommerce_currency should return separate field for symbol #15101

Closed
belcherj opened this issue May 16, 2017 · 2 comments
Closed

API - woocommerce_currency should return separate field for symbol #15101

belcherj opened this issue May 16, 2017 · 2 comments
Labels
type: enhancement The issue is a request for an enhancement.

Comments

@belcherj
Copy link
Contributor

When using the wc-api to get general settings /wc/v2/settings/general, the woocommerce_currency object has an options array that has the following format:

{AED: "United Arab Emirates dirham (د.إ)"}

This results in having to use a regex to separate the country and currency name from the currency symbol.

I propose that the options object should take this format:

{ AED: { country: "United Arab Emirates", currency: "dirham", symbol: "د.إ" } }

@belcherj belcherj added the type: enhancement The issue is a request for an enhancement. label May 16, 2017
@belcherj
Copy link
Contributor Author

@mattyza This is the enhancement reuqest that we talked about on Friday.

@mikejolley
Copy link
Member

I've moved this to the API dev repo here: woocommerce/wc-api-dev#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants