Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

São Tomé and Príncipe dobra has old currency code #23944

Closed
jpknz opened this issue Jun 16, 2019 · 1 comment · Fixed by #23950
Closed

São Tomé and Príncipe dobra has old currency code #23944

jpknz opened this issue Jun 16, 2019 · 1 comment · Fixed by #23950
Labels
type: enhancement The issue is a request for an enhancement. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.

Comments

@jpknz
Copy link

jpknz commented Jun 16, 2019 •
edited

get_woocommerce_currencies() will return STD for the São Tomé and Príncipe dobra. This currency and code was retired in 2018. The new São Tomé and Príncipe dobra has a code of STN.

See the below for confirmation
https://en.wikipedia.org/wiki/S%C3%A3o_Tom%C3%A9_and_Pr%C3%ADncipe_dobra
image

Expected behavior
STN returned for São Tomé and Príncipe dobra when get_woocommerce_currencies() called.

See also #23943
@peterfabian peterfabian added the type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. label Jun 17, 2019
@parmarhardip parmarhardip mentioned this issue Jun 18, 2019
Merged
@kloon kloon added type: enhancement The issue is a request for an enhancement. has pull request labels Jun 19, 2019
@kloon
Copy link
Member

kloon commented Jun 19, 2019

See #23950

@kloon kloon closed this as completed Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement The issue is a request for an enhancement. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team.
Projects
None yet
Milestone
No milestone
3 participants
@kloon @peterfabian @jpknz