Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COT] Propose ways for plugins and extensions to declare compatibility with custom order tables. #32920

Closed
vedanshujain opened this issue May 9, 2022 · 8 comments
Assignees
Labels
focus: custom order tables / HPOS Issues related to High-Performance Order Storage (HPOS) née Custom Order Tables. plugin: woocommerce Issues related to the WooCommerce Core plugin. type: task The issue is an internally driven task (e.g. from another A8c team).

Comments

@vedanshujain
Copy link
Contributor

When we rollout, all plugins and extensions will not be compatible with custom order tables, and we should display this to the merchant if they enable COT for a painless experience.

This could be a filter that extensions can use to declare compatibility, or this could be a plugin header field. Note that we may eventually roll our custom tables for products, customers and other entities, so ideally solution here should be extensible to these future enhancements as well.

@vedanshujain vedanshujain created this issue from a note in High Performance Order Storage (To do) May 9, 2022
@github-actions github-actions bot added the status: awaiting triage This is a newly created issue waiting for triage. label May 9, 2022
@vedanshujain vedanshujain added type: task The issue is an internally driven task (e.g. from another A8c team). focus: custom order tables / HPOS Issues related to High-Performance Order Storage (HPOS) née Custom Order Tables. plugin: woocommerce Issues related to the WooCommerce Core plugin. and removed status: awaiting triage This is a newly created issue waiting for triage. labels May 9, 2022
@vedanshujain vedanshujain moved this from To do - Nice to have to To do - Important in High Performance Order Storage May 9, 2022
@vedanshujain vedanshujain moved this from To do - Now to To do - Next in High Performance Order Storage May 9, 2022
@vedanshujain
Copy link
Contributor Author

We should also look into ways for plugins to find out whether a feature is implemented or not, and then plugins should have ways to declare support for particular feature.

@vedanshujain vedanshujain changed the title [COT] Add a way for plugins and extensions to declare compatibility with custom order tables. [COT] Propose ways for plugins and extensions to declare compatibility with custom order tables. May 9, 2022
@vedanshujain vedanshujain moved this from To do - Next to To do - Now in High Performance Order Storage May 16, 2022
@vedanshujain vedanshujain moved this from To do - Now to To do - Next in High Performance Order Storage Jun 13, 2022
@wnolfm
Copy link

wnolfm commented Jul 14, 2022

For this you could implement something like wc_add_support() and wc_get_support(), modeled after add_theme_support() and get_theme_support().

Such as: wc_add_support( 'custom-order-tables', ...$args );

Just a thought.

@vedanshujain vedanshujain moved this from To do - Next to To do - Now in High Performance Order Storage Jul 19, 2022
@Konamiman Konamiman moved this from To do - Now to In progress in High Performance Order Storage Aug 1, 2022
@Konamiman Konamiman self-assigned this Aug 1, 2022
@Konamiman
Copy link
Contributor

Proposal: p7bje6-4kh-p2

@Konamiman Konamiman moved this from In progress to Done in High Performance Order Storage Aug 2, 2022
@rrennick
Copy link
Contributor

@Konamiman This one could be closed?

@Konamiman
Copy link
Contributor

This one could be closed?

Yes, as we implemented the features engine already.

@maddisondesigns
Copy link

@Konamiman @rrennick Hi, Just wondering what the solution is here. It's mentioned that the feature has been implemented, but no mention of how plugin developers should actually declare compatibility.

@rrennick
Copy link
Contributor

@maddisondesigns You can find that at https://github.com/woocommerce/woocommerce/wiki/High-Performance-Order-Storage-Upgrade-Recipe-Book#declaring-extension-incompatibility.

@maddisondesigns
Copy link

@rrennick Thanks for that link. It's much appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: custom order tables / HPOS Issues related to High-Performance Order Storage (HPOS) née Custom Order Tables. plugin: woocommerce Issues related to the WooCommerce Core plugin. type: task The issue is an internally driven task (e.g. from another A8c team).
Projects
Development

No branches or pull requests

5 participants