Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't update catalogue image sizes #35

Closed
leewillis77 opened this issue Oct 2, 2011 · 6 comments
Closed

Can't update catalogue image sizes #35

leewillis77 opened this issue Oct 2, 2011 · 6 comments
Assignees

Comments

@leewillis77
Copy link
Contributor

Using latest git as of time of report, any attempt to update the image size settings ( WooCommerce > Settings > Catalog > Image Options ) results in them just defaulting back to standard. It looks like they do temporarily get saved in the DB, but then get overwritten again somewhere.

@mikejolley
Copy link
Member

I think they are being forced by the theme; woostore? WooTique?

@studioromeo
Copy link

Check for !important declarations ;) Those badboys will override absolutely everything which is why I try and avoid them. Failing that any CSS height/width thats applied to an image will override it's standard height/width values.

Easy way to check if your in chrome/firefox is to right click on the image and click on inspect element.
Firefox will need firebug installing first though (https://addons.mozilla.org/en-US/firefox/addon/firebug/).

Hope this helps :)

@mikejolley
Copy link
Member

@studioromeo - your right the CSS affects images sizes on the front-end, but in this case I think lee is referring to the actual saving of the image sizes in settings - few of the themes are currently forcing the size options.

@ghost ghost assigned jameskoster Oct 2, 2011
@studioromeo
Copy link

@mikejolley that's true although the user defined values should never be overridden no? It could be a number of things however css is where I would check first with any presentation related issue. Inspecting elements reveals all..nearly :D

@leewillis77
Copy link
Contributor Author

Mike's on the money. It's the settings in the admin that don't hold the user-entered values. He's also right that it's the theme that's resetting them (Wootique in this case). So this is probably a "bug" in Wootique. Ideally these fields would show as disabled (With a message) - although I guess woocommerce needs a patch to support that - there doesn't seem an obvious filter to allow this (The options array is filtered, but I can't see a way of toggling disabled/enabled or adding extra content.

@mikejolley
Copy link
Member

I've made the options clearer, and instructed Jay to only change the value on theme install so they can be changed by the user if they make customisations. That should clear up the issue for now.

@troyibm troyibm mentioned this issue Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants