Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated empty state for Attributes #38104

Closed
4 tasks
Tracked by #37839
mattsherman opened this issue May 3, 2023 · 0 comments · Fixed by #38126
Closed
4 tasks
Tracked by #37839

Updated empty state for Attributes #38104

mattsherman opened this issue May 3, 2023 · 0 comments · Fixed by #38126
Assignees
Labels
focus: product management Related to product creation and editing. plugin: woocommerce Issues related to the WooCommerce Core plugin. type: enhancement The issue is a request for an enhancement.

Comments

@mattsherman
Copy link
Contributor

mattsherman commented May 3, 2023

Before

Empty state when no global attributes exist:

Screenshot 2023-05-04 at 09 22 57

Empty state when global attributes exist:

Screenshot 2023-05-04 at 09 21 08

After (Design)

Empty state whenever no attributes are assigned to a product:

zs56kcy53K7GoGhgyjcQ2R-fi-365-39439&t=IlDQFEuvZsBvigFP-4

image

Acceptance criteria

  • We no longer check if any global attributes exist in the store. The empty state with the new attribute form is always shown when no attributes are added to the product (custom or global).
  • The empty state with the attribute creation form replaces the empty state with the badge icon.
  • The list has the same controls implemented in [Enhancement]: Add new empty state shown when no attributes #37151 (with the Add new and Add existing buttons).
  • If an existing (global) attribute is added when only an empty attribute create form is showing (no other attributes on product), the empty attribute create form is removed
@mattsherman mattsherman self-assigned this May 3, 2023
@github-actions github-actions bot added the status: awaiting triage This is a newly created issue waiting for triage. label May 3, 2023
@mattsherman mattsherman added focus: product management Related to product creation and editing. plugin: woocommerce Issues related to the WooCommerce Core plugin. type: enhancement The issue is a request for an enhancement. and removed status: awaiting triage This is a newly created issue waiting for triage. labels May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: product management Related to product creation and editing. plugin: woocommerce Issues related to the WooCommerce Core plugin. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant