-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product Editor Onboarding: Create new CES modal #38576
Comments
@pmcpinto we can pass this in as an array to tracks right? |
Important note... We already have |
Your partially correct, although instead of these being individual boolean prop values, it would be an array/list: |
Yes. I think that will work well. |
@mattsherman could we update the ces feedback track name though to be more generic instead of |
Description
When a user turns off the new product editor we want to show a CES modal to get the users feedback. This CES modal is a little different from the one we are currently using and includes a list of check boxes instead of ratings (see design ).
Implementation notes
We already have
ProductMVPFeedbackModal
, which appears to be basically what we want, with a few style tweaks.We should create this version, but as part of this it might be worth creating some re-usable components within the CES modal incase we have to create an alternate version in the future as well. Maybe just adding support in the config for the new question type would be enough?
Design
lj4AUMJnpMtUe7XqyvOONq-fi-1338_138709
Acceptance criteria
ces_feedback
track when user clicksSend
ces_feedback
track should include What made you turn off the new product form? values as a property (creating unique keys for this is fine)The text was updated successfully, but these errors were encountered: