Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Editor Onboarding: Create new CES modal #38576

Closed
5 tasks
louwie17 opened this issue Jun 2, 2023 · 6 comments · Fixed by #38592
Closed
5 tasks

Product Editor Onboarding: Create new CES modal #38576

louwie17 opened this issue Jun 2, 2023 · 6 comments · Fixed by #38592
Assignees
Labels
focus: new product ux revamped product management experience focus: product management Related to product creation and editing.

Comments

@louwie17
Copy link
Contributor

louwie17 commented Jun 2, 2023

Description

When a user turns off the new product editor we want to show a CES modal to get the users feedback. This CES modal is a little different from the one we are currently using and includes a list of check boxes instead of ratings (see design ).

Implementation notes

We already have ProductMVPFeedbackModal, which appears to be basically what we want, with a few style tweaks.

We should create this version, but as part of this it might be worth creating some re-usable components within the CES modal incase we have to create an alternate version in the future as well. Maybe just adding support in the config for the new question type would be enough?

Design

Image

lj4AUMJnpMtUe7XqyvOONq-fi-1338_138709

Acceptance criteria

  • Add support for new CES modal with a checkbox field as shown in the design
  • Show new CES modal when user clicks use classic editor or turn it off within the old product editor. We could just expose a query param?
  • What made you turn off the new product form? should be required
  • New CES modal should act the same as the current one and trigger a ces_feedback track when user clicks Send
  • ces_feedback track should include What made you turn off the new product form? values as a property (creating unique keys for this is fine)
@louwie17 louwie17 added focus: product management Related to product creation and editing. focus: new product ux revamped product management experience labels Jun 2, 2023
@github-actions github-actions bot added the status: awaiting triage This is a newly created issue waiting for triage. label Jun 2, 2023
@louwie17
Copy link
Contributor Author

louwie17 commented Jun 2, 2023

ces_feedback track should include What made you turn off the new product form? values as a property (creating unique keys for this is fine)

@pmcpinto we can pass this in as an array to tracks right?

@mattsherman mattsherman self-assigned this Jun 2, 2023
@mattsherman
Copy link
Contributor

Important note...

We already have ProductMVPFeedbackModal, which appears to be basically what we want, with a few style tweaks.

@mattsherman mattsherman removed the status: awaiting triage This is a newly created issue waiting for triage. label Jun 2, 2023
@mattsherman mattsherman removed their assignment Jun 2, 2023
@joshuatf joshuatf self-assigned this Jun 2, 2023
@pmcpinto
Copy link
Collaborator

pmcpinto commented Jun 5, 2023

@pmcpinto we can pass this in as an array to tracks right?

Hey @louwie17 just to clarify how it will work: if the user selects "missing features" and "missing plugins" the prop value will be: missing-features, missing-plugins. Correct?

@louwie17
Copy link
Contributor Author

louwie17 commented Jun 5, 2023

Hey @louwie17 just to clarify how it will work: if the user selects "missing features" and "missing plugins" the prop value will be: missing-features, missing-plugins. Correct?

Your partially correct, although instead of these being individual boolean prop values, it would be an array/list: checked: [ 'missing-features', 'missing-plugins' ].
Would that still be queryable or usable within the track funnels?

@pmcpinto
Copy link
Collaborator

pmcpinto commented Jun 5, 2023

Yes. I think that will work well.

@louwie17
Copy link
Contributor Author

louwie17 commented Jun 5, 2023

We already have ProductMVPFeedbackModal, which appears to be basically what we want, with a few style tweaks.

@mattsherman could we update the ces feedback track name though to be more generic instead of product_mvp_feedback. See your Slack thread for more context: p1685707857873529-slack-C01CMSA1VHS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: new product ux revamped product management experience focus: product management Related to product creation and editing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants