Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacing needs to be change in/between elements on Cart and Checkout #42108

Closed
ralucaStan opened this issue Nov 13, 2023 · 4 comments · Fixed by #44160
Closed

Spacing needs to be change in/between elements on Cart and Checkout #42108

ralucaStan opened this issue Nov 13, 2023 · 4 comments · Fixed by #44160
Assignees
Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. focus: cart Issues related to the cart. focus: checkout Issues related to checkout page. focus: global styles Issues that involve styles/css/layout structure. team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues type: enhancement The issue is a request for an enhancement.

Comments

@ralucaStan
Copy link
Contributor

Describe the bug

This is a follow-up of woocommerce/woocommerce-blocks#10889.
We need to improve the spacing overall in the Checkout blocks.

Expected behavior

See the screenshots section below

Screenshots

vertical-spacing-2

Screenshot 2023-11-12 at 4 59 23 AM Screenshot 2023-11-12 at 5 16 20 AM
@ralucaStan ralucaStan added type: bug The issue is a confirmed bug. block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. focus: global styles Issues that involve styles/css/layout structure. labels Nov 13, 2023
@senadir senadir added the team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues label Nov 28, 2023
@nerrad nerrad added focus: cart Issues related to the cart. focus: checkout Issues related to checkout page. labels Nov 29, 2023
@ObliviousHarmony ObliviousHarmony transferred this issue from woocommerce/woocommerce-blocks Dec 11, 2023
@mikejolley mikejolley added type: enhancement The issue is a request for an enhancement. and removed type: bug The issue is a confirmed bug. labels Dec 13, 2023
@tarunvijwani tarunvijwani self-assigned this Jan 8, 2024
@tarunvijwani
Copy link
Contributor

@elizaan36 During the initial review of the cart page, I found some areas for improvement in other elements on the Cart page. I would appreciate your thoughts on adding some spacing around them.

After updating the suggested gaps Needs improvement
image image

I was also thinking of revisiting all the elements, including the cross-sells section, and having the production ready design in Figma for spacing as we did in the last issue to reduce the back-and-forth discussions. I'd love to hear your thoughts about it.

Here are the current Cart and Checkout screens in the Twenty Twenty-Four theme(without any adjustments):
image

image
image
image

@nikkivias
Copy link

nikkivias commented Jan 10, 2024

@tarunvijwani I can look into this and mockup spacing only improvements to the existing experience

@elizaan36
Copy link
Contributor

Thanks @tarunvijwani for bringing this up. Will be great to have a consistent vertical grid across the Cart, Checkout, and Order Confirmation.

And thanks @nikkivias for looking into this! In the first comment screenshot, I used a 16/24 spacing for Cart and Checkout, pulling the relevant variables from this list.

@nikkivias
Copy link

Hi Tarun, I've laid out the spacing specs on this Figma file for checkout and cart. For mobile versions, i only add specs where it deviates from desktop. Please feel free to tag me on Figma if you have any questions, or I missed anything. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. focus: cart Issues related to the cart. focus: checkout Issues related to checkout page. focus: global styles Issues that involve styles/css/layout structure. team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants