Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement more semantic naming for templates and patterns #42149

Open
sunyatasattva opened this issue Oct 31, 2023 · 2 comments
Open

Implement more semantic naming for templates and patterns #42149

sunyatasattva opened this issue Oct 31, 2023 · 2 comments
Assignees
Labels
focus: FSE Issues related to Full Site Editing needs: developer feedback Issues that need feedback from one of the WooCommerce Core developers. status: on hold The issue is currently not prioritized. team: Kirigami & Origami type: enhancement The issue is a request for an enhancement.

Comments

@sunyatasattva
Copy link
Contributor

WordPress 6.4 introduces a way to rename group blocks (WordPress/gutenberg#54426) to make their intention more explicit and navigating through the tree-view much clearer.

We should go through our patterns and templates and make sure our groups are named in a meaningful way for users to make sense of them.

@sunyatasattva sunyatasattva added type: enhancement The issue is a request for an enhancement. focus: FSE Issues related to Full Site Editing labels Oct 31, 2023
@sunyatasattva sunyatasattva self-assigned this Oct 31, 2023
@Aljullu
Copy link
Contributor

Aljullu commented Nov 7, 2023

I was going though Twenty-Twenty Four templates and it looks like none of them uses this feature. While Group blocks can be renamed by users, they come with the Group name by default:

Index template Pages template Page no title template
imatge imatge imatge

In my opinion, WooCommerce templates should follow the same approach: we allow renaming Groups (which is already possible), but by default they are named Group.

So IMO I wouldn't do anything here. What do you think?

@sunyatasattva sunyatasattva added the status: on hold The issue is currently not prioritized. label Nov 13, 2023
@sunyatasattva
Copy link
Contributor Author

Let's put this on hold. I agree we should be consistent with Gutenberg; however, I think we should also push for innovation, which is what we talked about with Matías at the meetup as well. I'll pursue this conversation further.

@nerrad nerrad added needs: developer feedback Issues that need feedback from one of the WooCommerce Core developers. team: Kirigami & Origami labels Nov 29, 2023
@ObliviousHarmony ObliviousHarmony transferred this issue from woocommerce/woocommerce-blocks Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: FSE Issues related to Full Site Editing needs: developer feedback Issues that need feedback from one of the WooCommerce Core developers. status: on hold The issue is currently not prioritized. team: Kirigami & Origami type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

No branches or pull requests

3 participants