Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge the markup from atomic/blocks/product-elements/ with base/components/cart-checkout/ #42680

Open
Aljullu opened this issue Mar 13, 2020 · 10 comments
Open

Merge the markup from atomic/blocks/product-elements/ with base/components/cart-checkout/ #42680

Aljullu opened this issue Mar 13, 2020 · 10 comments
Labels
block: checkout Issues related to the checkout block. focus: checkout Issues related to checkout page. priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues type: cooldown Things that are queued for a cooldown period (assists with planning). type: refactor The issue/PR is related to refactoring.

Comments

@Aljullu
Copy link
Contributor

Aljullu commented Mar 13, 2020 •
edited

Initially discussed in woocommerce/woocommerce-blocks#1959 (comment).

We have very similar components in atomic/blocks/product-elements/ (used for the All Products and Single Product blocks) and base/components/cart-checkout/ (used for the Cart and Checkout blocks). This issue is about moving the markup from Atomic blocks to independent components as much as possible. Probably that would mean moving some components out of the cart-checkout subfolder.
@Aljullu Aljullu added type: refactor The issue/PR is related to refactoring. type: cooldown Things that are queued for a cooldown period (assists with planning). labels Mar 13, 2020
@Aljullu
Copy link
Contributor Author

Aljullu commented May 28, 2020

I'm going to add this to the Block Styling epic. If we want to have a set of class names that themes can rely on, we should consolidate our blocks on a set of components.

In WC Core themes can style all prices with something like:

.price {
	ins {
		font-weight: 400;
	}
}

In Blocks, that would not be possible because we are rendering prices in different components with different class names (/base/components/cart-checkout/product-price/index.js and /atomic/components/product/price/index.js, for example).

@Aljullu Aljullu mentioned this issue May 28, 2020
Merged
@nerrad nerrad added the block: checkout Issues related to the checkout block. label Jun 7, 2020
@Aljullu Aljullu mentioned this issue Jun 10, 2020
Closed
@Aljullu Aljullu self-assigned this Aug 27, 2020
@Aljullu Aljullu changed the title Investigate if it might be worth merging atomic/components/product/ with base/components/cart-checkout/ Merge the markup from atomic/blocks/product-elements/ with base/components/cart-checkout/ Aug 27, 2020
This was referenced Aug 27, 2020
Closed
Merged
@Aljullu Aljullu removed their assignment Sep 2, 2020
@nerrad nerrad removed the type: cooldown Things that are queued for a cooldown period (assists with planning). label Sep 22, 2020
@nerrad nerrad added the type: cooldown Things that are queued for a cooldown period (assists with planning). label Nov 15, 2020
@Aljullu Aljullu mentioned this issue Dec 16, 2020
Merged
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Issues that have no had any activity for some time. label Jan 15, 2021
@nerrad nerrad removed the status: stale Issues that have no had any activity for some time. label Jan 20, 2021
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Issues that have no had any activity for some time. label Mar 22, 2021
@nerrad nerrad removed the status: stale Issues that have no had any activity for some time. label Mar 31, 2021
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Issues that have no had any activity for some time. label May 31, 2021
@nerrad nerrad removed the status: stale Issues that have no had any activity for some time. label Jun 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2021

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Issues that have no had any activity for some time. label Aug 2, 2021
@nerrad nerrad removed the status: stale Issues that have no had any activity for some time. label Aug 3, 2021
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Issues that have no had any activity for some time. label Oct 14, 2021
@Aljullu Aljullu removed the status: stale Issues that have no had any activity for some time. label Oct 14, 2021
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Issues that have no had any activity for some time. label Dec 14, 2021
@nerrad nerrad removed the status: stale Issues that have no had any activity for some time. label Dec 15, 2021
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Issues that have no had any activity for some time. label Feb 14, 2022
@Aljullu Aljullu removed the status: stale Issues that have no had any activity for some time. label Feb 14, 2022
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Issues that have no had any activity for some time. label Apr 30, 2022
@Aljullu Aljullu removed the status: stale Issues that have no had any activity for some time. label May 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2022

This issue has been marked as stale because it has not seen any activity within the past 60 days. Our team uses this tool to help surface issues for review. If you are the author of the issue there's no need to comment as it will be looked at.

Internal: After 10 days with no activity this issue will be automatically be closed.

@github-actions github-actions bot added the status: stale Issues that have no had any activity for some time. label Jul 8, 2022
@Aljullu Aljullu reopened this Jul 19, 2022
@github-actions github-actions bot removed the status: stale Issues that have no had any activity for some time. label Aug 11, 2022
@nerrad nerrad added the team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues label Dec 1, 2023
@ObliviousHarmony ObliviousHarmony transferred this issue from woocommerce/woocommerce-blocks Dec 11, 2023
@ralucaStan ralucaStan added the focus: checkout Issues related to checkout page. label Dec 14, 2023
@ralucaStan ralucaStan added the priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
block: checkout Issues related to the checkout block. focus: checkout Issues related to checkout page. priority: normal The issue/PR is of normal priority—not many people are affected or there’s a workaround, etc. team: Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues type: cooldown Things that are queued for a cooldown period (assists with planning). type: refactor The issue/PR is related to refactoring.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nerrad @ralucaStan @Aljullu